[GitHub] [ignite] Vladsz83 commented on a change in pull request #7514: IGNITE-12773 : Reduce number of cluster deactivation methods in internal API.

[GitBox <gi...@apache.org>]

Vladsz83 commented on a change in pull request #7514: IGNITE-12773 : Reduce number of cluster deactivation methods in internal API.
URL: https://github.com/apache/ignite/pull/7514#discussion_r391602596
 
 

 ##########
 File path: modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/ChangeStateCommandHandlerTest.java
 ##########
 @@ -87,23 +89,23 @@
     public void testActivateDeActivate() throws GridClientException {
         GridClientClusterState state = client.state();
 
-        boolean active = state.active();
+        boolean active = state.state() == ACTIVE;
 
         assertTrue(active);
 
-        state.active(false);
+        state.state(INACTIVE, true);
 
         IgniteEx ig1 = grid(0);
         IgniteEx ig2 = grid(1);
 
         assertFalse(ig1.active());
         assertFalse(ig2.active());
-        assertFalse(state.active());
+        assertEquals(state.state(), INACTIVE);
 
-        state.active(true);
+        state.state(ACTIVE, true);
 
 Review comment:
   > There is no cluster deactivation, `forceDeactivation` should be false.
   
   Previous invocations were considered forced regardless of certain state. Shouldn't we do the same way?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services