You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/26 09:25:34 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4626: server: fix failed to remove template/iso if upload from local fails
ustcweizhou opened a new pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626
### Description
This PR fixes the issue that failed to remove template/iso if upload from local fails
When upload template/iso/volume from local fails, the install_path will not be a full path of file so removing it will fail.
```
mysql> select install_path from template_store_ref;
+--------------------------------------------------------------------+
| install_path |
+--------------------------------------------------------------------+
| template/tmpl/1/3/805f4763-248e-40ec-b79a-b868cc480d0a.qcow2 |
| template/tmpl/1/4/c7e32c9e-5e72-3726-85cf-aa5ccd84118d.qcow2 |
| template/tmpl/2/201/bc4f4f08-138a-31b8-af1a-d4450eff7982.qcow2 |
| template/tmpl/2/202 |
| template/tmpl/2/203/203-2-d47f8cde-a2a8-31e7-a826-2628ad98a6c8.iso |
| template/tmpl/2/204 |
| template/tmpl/5/205 |
| template/tmpl/2/206 |
| template/tmpl/2/207 |
| template/tmpl/2/208 |
| template/tmpl/2/209 |
| template/tmpl/2/210 |
+--------------------------------------------------------------------+
12 rows in set (0.00 sec)
mysql> select install_path from volume_store_ref;
+---------------------------------------------------------+
| install_path |
+---------------------------------------------------------+
| volumes/2/22 |
| volumes/2/19/f93face9-6521-4184-b89a-cb07f86bbae8.qcow2 |
| volumes/2/23 |
| volumes/2/24 |
+---------------------------------------------------------+
4 rows in set (0.00 sec)
```
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-773996183
> NotUploaded
@shwstppr NotUploaded is the initialed state of volumes/template/iso when it is uploaded from local.
when upload starts, it will be transited to UploadInProgress
when upload failed, it will be transited to UploadError
I think deleting template/iso in NotUploaded state should not be allowed (same as volumes).
when upload fails (by default template/isos/volumes will be in UploadError state after 1 hour), we can remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768907454
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2612
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd edited a comment on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-786457657
ping @ustcweizhou @shwstppr @Pearl1594 - should we merge this on 4.14 now, or change base/milestone to 4.15.1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-771541886
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769619620
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-770025172
<b>Trillian test result (tid-3453)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45950 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4626-t3453-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3613.69 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 3601.97 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 38.33 | test_kubernetes_clusters.py
test_02_create_template_with_checksum_sha1 | `Error` | 5.11 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 5.11 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 5.12 | test_templates.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769620557
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-786457657
ping @shwstppr @Pearl1594 - should we merge this on 4.14 now, or change base/milestone to 4.15.1.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768880787
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769620026
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-771983353
<b>Trillian test result (tid-3472)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4626-t3472-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-768880150
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-771542410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-769619620
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-771541886
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4626: server: fix failed to remove template/iso if upload from local fails
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4626:
URL: https://github.com/apache/cloudstack/pull/4626#issuecomment-771542410
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org