You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "abhinav7sinha (via GitHub)" <gi...@apache.org> on 2023/04/01 13:07:37 UTC
[GitHub] [fineract] abhinav7sinha opened a new pull request, #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
abhinav7sinha opened a new pull request, #3094:
URL: https://github.com/apache/fineract/pull/3094
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1494934260
@abhinav7sinha Please dont forget to squash the commits!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abhinav7sinha commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "abhinav7sinha (via GitHub)" <gi...@apache.org>.
abhinav7sinha commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1500876265
checkStyle thinks that AccountNumberFormatEnumerations has a public/default constructor, but I'm using a lombok annotation to explicitly create a Prive constructor @NoArgsConstructor(access = AccessLevel.PRIVATE)
[ERROR] /home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/infrastructure/accountnumberformat/domain/AccountNumberFormatEnumerations.java:35:1: Utility classes should not have a public or default constructor.
Additionally, running spotlessCheck on my local mac didn't reveal this issue.
Do you have any ideas on how I could resolve this? Or do you think I may be missing something here?
@adamsaghy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abhinav7sinha commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "abhinav7sinha (via GitHub)" <gi...@apache.org>.
abhinav7sinha commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1500865398
> > @abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR! Please try to rebase instead of merge.
>
> got it @adamsaghy I'm converting it to a draft while I test the changes some more
@adamsaghy I've marked this as ready for review now, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1494612970
@abhinav7sinha Please dont forget to run a checkstyle check before committing any new code. It is failing with checkstyle errors as of now.
You can run it by ` ./gradlew spotlessApply`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics closed pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics closed pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
URL: https://github.com/apache/fineract/pull/3094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abhinav7sinha commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "abhinav7sinha (via GitHub)" <gi...@apache.org>.
abhinav7sinha commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1495048805
> @abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR! Please try to rebase instead of merge.
got it @adamsaghy
I'm converting it to a draft while I test the changes some more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1585300021
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abhinav7sinha commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "abhinav7sinha (via GitHub)" <gi...@apache.org>.
abhinav7sinha commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1494625837
> @abhinav7sinha Please dont forget to run a checkstyle check before committing any new code. It is failing with checkstyle errors as of now. You can run it by ` ./gradlew spotlessApply`
Understood, thanks. Doing so now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1494989305
@abhinav7sinha Unfortunately, it is not correct as you have merged other people PRs into your PR!
Please try to rebase instead of merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] abhinav7sinha commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "abhinav7sinha (via GitHub)" <gi...@apache.org>.
abhinav7sinha commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1494985408
> @abhinav7sinha Please dont forget to squash the commits!
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #3094: Introduce Lombok to accountnumberformat module (FINERACT-1727)
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #3094:
URL: https://github.com/apache/fineract/pull/3094#issuecomment-1541610387
> Do you have any ideas on how I could resolve this? Or do you think I may be missing something here?
Don't use lombok for that. That's all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org