[GitHub] jvrao commented on a change in pull request #1586: Get currentEnsemble from ledger rather than directly from metadata

[GitBox <gi...@apache.org>]

jvrao commented on a change in pull request #1586: Get currentEnsemble from ledger rather than directly from metadata
URL: https://github.com/apache/bookkeeper/pull/1586#discussion_r208804008
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadLacOp.java
 ##########
 @@ -62,12 +66,12 @@
         this.cb = cb;
         this.numResponsesPending = lh.getLedgerMetadata().getEnsembleSize();
         this.coverageSet = lh.distributionSchedule.getCoverageSet();
+        this.currentEnsemble = lh.getCurrentEnsemble();
     }
 
     public void initiate() {
-        LedgerMetadata metadata = lh.getLedgerMetadata();
-        for (int i = 0; i < metadata.currentEnsemble.size(); i++) {
-            lh.bk.getBookieClient().readLac(metadata.currentEnsemble.get(i),
+        for (int i = 0; i < currentEnsemble.size(); i++) {
+            lh.bk.getBookieClient().readLac(currentEnsemble.get(i),
 
 Review comment:
   @eolivelli can you elaborate why you made 'perfect' comment just for this? Just curious. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services