You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2025/10/01 08:03:33 UTC

[PR] SLING-11422 No longer embed Events API [sling-org-apache-sling-event]

kwin opened a new pull request, #46:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/46

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-11422 No longer embed Events API [sling-org-apache-sling-event]

Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on code in PR #46:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/46#discussion_r2410793780


##########
bnd.bnd:
##########
@@ -8,18 +8,13 @@ Import-Package: \
     javax.servlet;resolution:=optional,\
     javax.annotation;version="[0.0,2)",\
     *
-Export-Package: \
-    org.apache.sling.event.jobs,\
-    org.apache.sling.event.jobs.consumer,\
-    org.apache.sling.event.jobs.jmx
 
 -conditionalpackage: \
     org.apache.jackrabbit.util,\
     org.apache.sling.commons.osgi,\
     org.apache.sling.event.api

Review Comment:
   Do you also need to remove this api reference?



##########
pom.xml:
##########
@@ -29,10 +29,10 @@
     </parent>
 
     <artifactId>org.apache.sling.event</artifactId>
-    <version>4.3.19-SNAPSHOT</version>
+    <version>4.4.0-SNAPSHOT</version>
 
-    <name>Apache Sling Event</name>
-    <description>Support for eventing.</description>
+    <name>Apache Sling Event Impl</name>

Review Comment:
   I would suggest also renaming the Jira release to 'Event Impl' to make this work with the Commiter CLI out of the box.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-11422 No longer embed Events API [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin merged PR #46:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-11422 No longer embed Events API [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #46:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/46#discussion_r2410829228


##########
pom.xml:
##########
@@ -29,10 +29,10 @@
     </parent>
 
     <artifactId>org.apache.sling.event</artifactId>
-    <version>4.3.19-SNAPSHOT</version>
+    <version>4.4.0-SNAPSHOT</version>
 
-    <name>Apache Sling Event</name>
-    <description>Support for eventing.</description>
+    <name>Apache Sling Event Impl</name>

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] SLING-11422 No longer embed Events API [sling-org-apache-sling-event]

Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #46:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/46#discussion_r2410813318


##########
bnd.bnd:
##########
@@ -8,18 +8,13 @@ Import-Package: \
     javax.servlet;resolution:=optional,\
     javax.annotation;version="[0.0,2)",\
     *
-Export-Package: \
-    org.apache.sling.event.jobs,\
-    org.apache.sling.event.jobs.consumer,\
-    org.apache.sling.event.jobs.jmx
 
 -conditionalpackage: \
     org.apache.jackrabbit.util,\
     org.apache.sling.commons.osgi,\
     org.apache.sling.event.api

Review Comment:
   yes, however this package does not exist at all, not sure if it ever did.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org