You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (JIRA)" <ji...@apache.org> on 2009/10/07 11:12:31 UTC
[jira] Created: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Add structure to SlingRequestProgressTracker messages
-----------------------------------------------------
Key: SLING-1139
URL: https://issues.apache.org/jira/browse/SLING-1139
Project: Sling
Issue Type: Improvement
Affects Versions: Engine 2.0.4
Reporter: Bertrand Delacretaz
Assignee: Bertrand Delacretaz
Priority: Minor
Fix For: Engine 2.0.6
The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
Here's an example of the current info (from http://localhost:8888/system/console/requests):
0 (2009-10-07 11:10:30) Starting Request Processing
0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
0 (2009-10-07 11:10:30) Starting ResourceResolution
6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
6 (2009-10-07 11:10:30) Starting ServletResolution
6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
6 (2009-10-07 11:10:30) Applying request filters
6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763151#action_12763151 ]
Alexander Klimetschek commented on SLING-1139:
----------------------------------------------
> I don't think we should do any indenting by anything in the tracker log dump
If it's parseable and happens in the recent requests console plugin, that's also fine I think.
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz resolved SLING-1139.
----------------------------------------
Resolution: Fixed
Implemented as suggested (revision 822709)
Example:
0 (2009-10-07 15:14:57) TIMER_START{Request Processing}
0 (2009-10-07 15:14:57) COMMENT timer_end format is {<elapsed msec>,<timer name>} <optional message>
0 (2009-10-07 15:14:57) LOG Method=GET, PathInfo=/index.html
0 (2009-10-07 15:14:57) TIMER_START{ResourceResolution}
2 (2009-10-07 15:14:57) TIMER_END{2,ResourceResolution} URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html
2 (2009-10-07 15:14:57) LOG Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
2 (2009-10-07 15:14:57) TIMER_START{ServletResolution}
3 (2009-10-07 15:14:57) TIMER_START{resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)}
9 (2009-10-07 15:14:57) TIMER_END{6,resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)} Using servlet org.apache.sling.servlets.get.DefaultGetServlet
9 (2009-10-07 15:14:57) TIMER_END{7,ServletResolution} URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet
9 (2009-10-07 15:14:57) LOG Applying request filters
9 (2009-10-07 15:14:57) LOG Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
9 (2009-10-07 15:14:57) TIMER_START{org.apache.sling.servlets.get.DefaultGetServlet#0}
10 (2009-10-07 15:14:57) LOG Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
13 (2009-10-07 15:14:57) TIMER_END{4,org.apache.sling.servlets.get.DefaultGetServlet#0}
13 (2009-10-07 15:14:57) TIMER_END{13,Request Processing} Request Processing
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763063#action_12763063 ]
Bertrand Delacretaz commented on SLING-1139:
--------------------------------------------
To go further I think we should improve the RequestProgressTracker to store more structured information like inclusion levels.
Also, some Sling components do not provide info to the RequestProgressTracker, this needs to be improved as well.
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-1139.
-----------------------------------
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763103#action_12763103 ]
Felix Meschberger commented on SLING-1139:
------------------------------------------
@Alex: I don't think we should do any indenting by anything in the tracker log dump
@Bertrand: We already have "log entries" for servlect includes. These might even be bracketed by timers, IIRC. But of, course we could define an explicit "includeStart"-"includeEnd" bracket (which extends the timer bracket). Such a bracket would probably be handled in the RequestDispatcher.include and .forward implementations.
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz resolved SLING-1139.
----------------------------------------
Resolution: Fixed
With the changes of revision 822628, the output of the same example is:
0 (2009-10-07 11:11:29) TIMER_START|Request Processing
0 (2009-10-07 11:11:29) Method=GET, PathInfo=/index.html
1 (2009-10-07 11:11:29) TIMER_START|ResourceResolution
5 (2009-10-07 11:11:29) TIMER_END|ResourceResolution|URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html|TIMER_ELAPSED=4 msec
6 (2009-10-07 11:11:29) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
6 (2009-10-07 11:11:29) TIMER_START|ServletResolution
7 (2009-10-07 11:11:29) TIMER_START|resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
24 (2009-10-07 11:11:29) TIMER_END|resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)|Using servlet org.apache.sling.servlets.get.DefaultGetServlet|TIMER_ELAPSED=17 msec
24 (2009-10-07 11:11:29) TIMER_END|ServletResolution|URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet|TIMER_ELAPSED=18 msec
26 (2009-10-07 11:11:29) Applying request filters
26 (2009-10-07 11:11:29) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
26 (2009-10-07 11:11:29) TIMER_START|org.apache.sling.servlets.get.DefaultGetServlet#0
26 (2009-10-07 11:11:29) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
27 (2009-10-07 11:11:29) TIMER_END|org.apache.sling.servlets.get.DefaultGetServlet#0|TIMER_ELAPSED=1 msec
27 (2009-10-07 11:11:29) TIMER_END|Request Processing|Request Processing|TIMER_ELAPSED=27 msec
The TIMER_ strings and pipe characters make that easier to parse.
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763059#action_12763059 ]
Alexander Klimetschek commented on SLING-1139:
----------------------------------------------
What about indenting filter / inclusion steps?
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz reopened SLING-1139:
----------------------------------------
Good idea, looks better, I'll do that
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-1139) Add structure to
SlingRequestProgressTracker messages
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762959#action_12762959 ]
Felix Meschberger commented on SLING-1139:
------------------------------------------
Sounds good, how about taking this one step further and format it completely different :
26 2009-10-07 11:11:29 TIMER_START{org.apache.sling.servlets.get.DefaultGetServlet#0}
26 2009-10-07 11:11:29 LOG Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
27 2009-10-07 11:11:29 TIMER_END{org.apache.sling.servlets.get.DefaultGetServlet#0,1}
27 2009-10-07 11:11:29 TIMER_END{Request Processing,27} Request Processing
three entry types:
TIMER_START{<name>} <optional message>
TIMER_END{<name>,<msecs>} <optional message>
LOG <message>
> Add structure to SlingRequestProgressTracker messages
> -----------------------------------------------------
>
> Key: SLING-1139
> URL: https://issues.apache.org/jira/browse/SLING-1139
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Engine 2.0.4
> Reporter: Bertrand Delacretaz
> Assignee: Bertrand Delacretaz
> Priority: Minor
> Fix For: Engine 2.0.6
>
>
> The SlingRequestProgressTracker messages contain useful timing information, structuring them a bit more would allow for parsing them to generate other representations.
> Here's an example of the current info (from http://localhost:8888/system/console/requests):
> 0 (2009-10-07 11:10:30) Starting Request Processing
> 0 (2009-10-07 11:10:30) Method=GET, PathInfo=/index.html
> 0 (2009-10-07 11:10:30) Starting ResourceResolution
> 6 (2009-10-07 11:10:30) URI=/index.html resolves to Resource=JcrNodeResource, type=nt:file, superType=null, path=/index.html, elapsed = 6ms
> 6 (2009-10-07 11:10:30) Resource Path Info: SlingRequestPathInfo: path='/index.html', selectorString='null', extension='null', suffix='null'
> 6 (2009-10-07 11:10:30) Starting ServletResolution
> 6 (2009-10-07 11:10:30) Starting resolveServlet(JcrNodeResource, type=nt:file, superType=null, path=/index.html)
> 6 (2009-10-07 11:10:30) Using servlet org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) URI=/index.html handled by Servlet=org.apache.sling.servlets.get.DefaultGetServlet, elapsed = 0ms
> 6 (2009-10-07 11:10:30) Applying request filters
> 6 (2009-10-07 11:10:30) Calling filter: org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter
> 6 (2009-10-07 11:10:30) Starting org.apache.sling.servlets.get.DefaultGetServlet#0
> 6 (2009-10-07 11:10:30) Using org.apache.sling.servlets.get.impl.helpers.StreamRendererServlet to render for extension=null
> 7 (2009-10-07 11:10:30) org.apache.sling.servlets.get.DefaultGetServlet#0, elapsed = 1ms
> 7 (2009-10-07 11:10:30) Request Processing ends, elapsed = 7ms
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.