You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by be...@apache.org on 2015/02/13 21:51:15 UTC

[1/3] cassandra git commit: Fix SSTableRewriter cleanup

Repository: cassandra
Updated Branches:
  refs/heads/cassandra-2.1 4223aad66 -> 26c204978
  refs/heads/trunk 370e72d0f -> e58a40e52


Fix SSTableRewriter cleanup

patch by benedict; reviewed by josh for CASSANDRA-8802


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/26c20497
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/26c20497
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/26c20497

Branch: refs/heads/cassandra-2.1
Commit: 26c2049783e5a680b125eea61f098f19549a820e
Parents: 4223aad
Author: Benedict Elliott Smith <be...@apache.org>
Authored: Fri Feb 13 20:50:31 2015 +0000
Committer: Benedict Elliott Smith <be...@apache.org>
Committed: Fri Feb 13 20:50:31 2015 +0000

----------------------------------------------------------------------
 CHANGES.txt                                                   | 1 +
 src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/26c20497/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 0d204a5..a35fa42 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.1.4
+ * Fix SSTableRewriter cleanup (CASSANDRA-8802)
  * Introduce SafeMemory for CompressionMetadata.Writer (CASSANDRA-8758)
  * 'nodetool info' prints exception against older node (CASSANDRA-8796)
  * Ensure SSTableReader.last corresponds exactly with the file end (CASSANDRA-8750)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/26c20497/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java b/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
index e6e4343..2ca3e6f 100644
--- a/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
+++ b/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
@@ -370,7 +370,7 @@ public class SSTableRewriter
 
         while (!finishedEarly.isEmpty())
         {
-            Finished f = finishedEarly.poll();
+            Finished f = finishedEarly.peek();
             if (f.writer.getFilePointer() > 0)
             {
                 if (f.reader != null)
@@ -389,6 +389,7 @@ public class SSTableRewriter
                 f.writer.abort();
                 assert f.reader == null;
             }
+            finishedEarly.poll();
         }
 
         if (throwLate)


[2/3] cassandra git commit: Fix SSTableRewriter cleanup

Posted by be...@apache.org.
Fix SSTableRewriter cleanup

patch by benedict; reviewed by josh for CASSANDRA-8802


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/26c20497
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/26c20497
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/26c20497

Branch: refs/heads/trunk
Commit: 26c2049783e5a680b125eea61f098f19549a820e
Parents: 4223aad
Author: Benedict Elliott Smith <be...@apache.org>
Authored: Fri Feb 13 20:50:31 2015 +0000
Committer: Benedict Elliott Smith <be...@apache.org>
Committed: Fri Feb 13 20:50:31 2015 +0000

----------------------------------------------------------------------
 CHANGES.txt                                                   | 1 +
 src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/26c20497/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 0d204a5..a35fa42 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,4 +1,5 @@
 2.1.4
+ * Fix SSTableRewriter cleanup (CASSANDRA-8802)
  * Introduce SafeMemory for CompressionMetadata.Writer (CASSANDRA-8758)
  * 'nodetool info' prints exception against older node (CASSANDRA-8796)
  * Ensure SSTableReader.last corresponds exactly with the file end (CASSANDRA-8750)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/26c20497/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java b/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
index e6e4343..2ca3e6f 100644
--- a/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
+++ b/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
@@ -370,7 +370,7 @@ public class SSTableRewriter
 
         while (!finishedEarly.isEmpty())
         {
-            Finished f = finishedEarly.poll();
+            Finished f = finishedEarly.peek();
             if (f.writer.getFilePointer() > 0)
             {
                 if (f.reader != null)
@@ -389,6 +389,7 @@ public class SSTableRewriter
                 f.writer.abort();
                 assert f.reader == null;
             }
+            finishedEarly.poll();
         }
 
         if (throwLate)


[3/3] cassandra git commit: Merge branch 'cassandra-2.1' into trunk

Posted by be...@apache.org.
Merge branch 'cassandra-2.1' into trunk


Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/e58a40e5
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/e58a40e5
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/e58a40e5

Branch: refs/heads/trunk
Commit: e58a40e5245676533ec1a99159165f3604967015
Parents: 370e72d 26c2049
Author: Benedict Elliott Smith <be...@apache.org>
Authored: Fri Feb 13 20:51:02 2015 +0000
Committer: Benedict Elliott Smith <be...@apache.org>
Committed: Fri Feb 13 20:51:02 2015 +0000

----------------------------------------------------------------------
 CHANGES.txt                                                   | 1 +
 src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cassandra/blob/e58a40e5/CHANGES.txt
----------------------------------------------------------------------
diff --cc CHANGES.txt
index 55774cb,a35fa42..e1ae69b
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@@ -1,63 -1,5 +1,64 @@@
 +3.0
 + * Add role based access control (CASSANDRA-7653, 8650)
 + * Avoid accessing partitioner through StorageProxy (CASSANDRA-8244, 8268)
 + * Upgrade Metrics library and remove depricated metrics (CASSANDRA-5657)
 + * Serializing Row cache alternative, fully off heap (CASSANDRA-7438)
 + * Duplicate rows returned when in clause has repeated values (CASSANDRA-6707)
 + * Make CassandraException unchecked, extend RuntimeException (CASSANDRA-8560)
 + * Support direct buffer decompression for reads (CASSANDRA-8464)
 + * DirectByteBuffer compatible LZ4 methods (CASSANDRA-7039)
 + * Group sstables for anticompaction correctly (CASSANDRA-8578)
 + * Add ReadFailureException to native protocol, respond
 +   immediately when replicas encounter errors while handling
 +   a read request (CASSANDRA-7886)
 + * Switch CommitLogSegment from RandomAccessFile to nio (CASSANDRA-8308)
 + * Allow mixing token and partition key restrictions (CASSANDRA-7016)
 + * Support index key/value entries on map collections (CASSANDRA-8473)
 + * Modernize schema tables (CASSANDRA-8261)
 + * Support for user-defined aggregation functions (CASSANDRA-8053)
 + * Fix NPE in SelectStatement with empty IN values (CASSANDRA-8419)
 + * Refactor SelectStatement, return IN results in natural order instead
 +   of IN value list order and ignore duplicate values in partition key IN restrictions (CASSANDRA-7981)
 + * Support UDTs, tuples, and collections in user-defined
 +   functions (CASSANDRA-7563)
 + * Fix aggregate fn results on empty selection, result column name,
 +   and cqlsh parsing (CASSANDRA-8229)
 + * Mark sstables as repaired after full repair (CASSANDRA-7586)
 + * Extend Descriptor to include a format value and refactor reader/writer
 +   APIs (CASSANDRA-7443)
 + * Integrate JMH for microbenchmarks (CASSANDRA-8151)
 + * Keep sstable levels when bootstrapping (CASSANDRA-7460)
 + * Add Sigar library and perform basic OS settings check on startup (CASSANDRA-7838)
 + * Support for aggregation functions (CASSANDRA-4914)
 + * Remove cassandra-cli (CASSANDRA-7920)
 + * Accept dollar quoted strings in CQL (CASSANDRA-7769)
 + * Make assassinate a first class command (CASSANDRA-7935)
 + * Support IN clause on any partition key column (CASSANDRA-7855)
 + * Support IN clause on any clustering column (CASSANDRA-4762)
 + * Improve compaction logging (CASSANDRA-7818)
 + * Remove YamlFileNetworkTopologySnitch (CASSANDRA-7917)
 + * Do anticompaction in groups (CASSANDRA-6851)
 + * Support user-defined functions (CASSANDRA-7395, 7526, 7562, 7740, 7781, 7929,
 +   7924, 7812, 8063, 7813, 7708)
 + * Permit configurable timestamps with cassandra-stress (CASSANDRA-7416)
 + * Move sstable RandomAccessReader to nio2, which allows using the
 +   FILE_SHARE_DELETE flag on Windows (CASSANDRA-4050)
 + * Remove CQL2 (CASSANDRA-5918)
 + * Add Thrift get_multi_slice call (CASSANDRA-6757)
 + * Optimize fetching multiple cells by name (CASSANDRA-6933)
 + * Allow compilation in java 8 (CASSANDRA-7028)
 + * Make incremental repair default (CASSANDRA-7250)
 + * Enable code coverage thru JaCoCo (CASSANDRA-7226)
 + * Switch external naming of 'column families' to 'tables' (CASSANDRA-4369) 
 + * Shorten SSTable path (CASSANDRA-6962)
 + * Use unsafe mutations for most unit tests (CASSANDRA-6969)
 + * Fix race condition during calculation of pending ranges (CASSANDRA-7390)
 + * Fail on very large batch sizes (CASSANDRA-8011)
 + * Improve concurrency of repair (CASSANDRA-6455, 8208)
 +
 +
  2.1.4
+  * Fix SSTableRewriter cleanup (CASSANDRA-8802)
   * Introduce SafeMemory for CompressionMetadata.Writer (CASSANDRA-8758)
   * 'nodetool info' prints exception against older node (CASSANDRA-8796)
   * Ensure SSTableReader.last corresponds exactly with the file end (CASSANDRA-8750)

http://git-wip-us.apache.org/repos/asf/cassandra/blob/e58a40e5/src/java/org/apache/cassandra/io/sstable/SSTableRewriter.java
----------------------------------------------------------------------