You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/06/16 15:31:40 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #31951: Fix a couple Airflow release doc errors
jedcunningham commented on code in PR #31951:
URL: https://github.com/apache/airflow/pull/31951#discussion_r1232405802
##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -583,15 +583,14 @@ Check if sources are the same as in the tag:
```bash
cd X.Y.Zrc1
tar -xvzf *-source.tar.gz
-pushd apache-airflow-X.Y.Zrc1
+pushd apache-airflow-X.Y.Z
diff -r airflow "${SOURCE_DIR}"
-popd && rm -rf apache-airflow-X.Y.Zrc1
+popd && rm -rf apache-airflow-X.Y.Z
```
The output should only miss some files - but they should not show any differences in the files:
```
-⌂6.50 [jarek:~/asf-dist/dev/airflow/2.6.2rc2/a] * 1 ‡ diff -r airflow ~/code/airflow/
Review Comment:
That was what I did initially actually, but after thinking about it, I don't think we need it. It already mentions the "output", meaning it's the result of the commands above. This is the same pattern we have for the [shasum check](https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md#sha512-sum-check) too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org