You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "PetteriAimonen (via GitHub)" <gi...@apache.org> on 2023/10/05 13:37:25 UTC

[I] Clean up Makefile/Kconfig dependency checks [nuttx-apps]

PetteriAimonen opened a new issue, #2106:
URL: https://github.com/apache/nuttx-apps/issues/2106

   Some of the application Makefiles have configuration checks that overlap dependencies given in Kconfig and Make.defs.
   Ideally each check should be done at only one place, and dependencies should be handled by Kconfig.
   
   Note that enabling *partial* functionality based on config checks in Makefile is fine, but if the whole application depends on some configuration item, that should be a dependency in Kconfig.
   
   Makefiles that have a duplicate check for `CONFIG_appname` in both Make.defs and Makefile:
   
   * fsutils/ipcfg
   * fsutils/mkfatfs
   * fsutils/mksmartfs
   * fsutils/passwd
   * netutils/dhcp6c
   * netutils/ping
   
   Makefiles that check for some other config item such as `CONFIG_NET_UDP`. In most cases the dependency is already in Kconfig and the Makefile check can be removed, in other cases dependency should be added to Kconfig:
   
   * netutils/dhcpc
   * netutils/dhcpd
   * netutils/discover
   * netutils/ftpc
   * netutils/ftpd
   * netutils/ntpclient
   * netutils/smtp
   * netutils/telnetc
   * netutils/tftpc
   * netutils/thttpd
   * netutils/webclient
   * netutils/webserver
   * netutils/xmlrpc
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org