You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/11/24 06:49:15 UTC
Review Request 28388: libprocess: Create IP address abstraction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28388/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos-git
Description
-------
Create an IP address abstraction such that every callsite does not need to check the family and get the right address.
Diffs
-----
3rdparty/libprocess/include/process/node.hpp 24132a5a9ff36a0fff3a25e7f7efce23777e3833
3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
Diff: https://reviews.apache.org/r/28388/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28388: libprocess: Create IP address abstraction
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28388/#review62757
-----------------------------------------------------------
Bad patch!
Reviews applied: [28383, 28384, 28385, 28386, 28387, 28388]
Failed command: ./support/apply-review.sh -n -r 28388
Error:
2014-11-24 06:56:58 URL:https://reviews.apache.org/r/28388/diff/raw/ [5146/5146] -> "28388.patch" [1]
error: patch failed: 3rdparty/libprocess/include/process/node.hpp:37
error: 3rdparty/libprocess/include/process/node.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 24, 2014, 5:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28388/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 5:49 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Create an IP address abstraction such that every callsite does not need to check the family and get the right address.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 24132a5a9ff36a0fff3a25e7f7efce23777e3833
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
>
> Diff: https://reviews.apache.org/r/28388/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28388: libprocess: Create IP address abstraction
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Nov. 24, 2014, 5:36 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/src/pid.cpp, line 145
> > <https://reviews.apache.org/r/28388/diff/1/?file=774079#file774079line145>
> >
> > probably should be some way to set the ip address which checks the family of the incoming in_addr and sets the right fields appropriately.
i will replace gethostbyname calls with getaddrinfo and create a method in IPAddress to make this calls transparent to the callsites.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28388/#review62804
-----------------------------------------------------------
On Nov. 24, 2014, 5:49 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28388/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 5:49 a.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Create an IP address abstraction such that every callsite does not need to check the family and get the right address.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 24132a5a9ff36a0fff3a25e7f7efce23777e3833
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
>
> Diff: https://reviews.apache.org/r/28388/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28388: libprocess: Create IP address abstraction
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28388/#review62804
-----------------------------------------------------------
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28388/#comment104938>
const net::IPAddress&
3rdparty/libprocess/include/process/node.hpp
<https://reviews.apache.org/r/28388/#comment104939>
look how much cleaner that is! yay!
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/28388/#comment104940>
probably should be some way to set the ip address which checks the family of the incoming in_addr and sets the right fields appropriately.
- Dominic Hamon
On Nov. 23, 2014, 9:49 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28388/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2014, 9:49 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Create an IP address abstraction such that every callsite does not need to check the family and get the right address.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/node.hpp 24132a5a9ff36a0fff3a25e7f7efce23777e3833
> 3rdparty/libprocess/include/process/pid.hpp 7dccf297ea473a9b19dd450f02c7ae4fd0c60a22
> 3rdparty/libprocess/src/pid.cpp a2c620ef0858ee03ca6d20264125f2c254697078
> 3rdparty/libprocess/src/process.cpp cf75b51fdae821c9b6c80ddcf2a56ba8bbc63f14
>
> Diff: https://reviews.apache.org/r/28388/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>