You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/05/06 23:21:30 UTC

[jira] Created: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Fix slightly confusing log from "-metaSave" on NameNode
-------------------------------------------------------

                 Key: HADOOP-5780
                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
             Project: Hadoop Core
          Issue Type: Bug
            Reporter: Raghu Angadi
            Priority: Minor



After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 

e.g. : {noformat}
Metasave: Blocks waiting for replication: 1
blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
{noformat}

"0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".

We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5780:
---------------------------------

    Attachment: HADOOP-5780.patch

Thanks Suresh. Updated patch fixes the spelling.

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707588#action_12707588 ] 

Hadoop QA commented on HADOOP-5780:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407573/HADOOP-5780.patch
  against trunk revision 772960.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/309/console

This message is automatically generated.

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5780:
---------------------------------

        Fix Version/s: 0.21.0
    Affects Version/s: 0.20.0
               Status: Patch Available  (was: Open)

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HADOOP-5780:
-------------------------------------------

    Component/s: dfs
    Description: 
After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 

e.g. : {noformat}
Metasave: Blocks waiting for replication: 1
blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
{noformat}

"0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".

We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

  was:

After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 

e.g. : {noformat}
Metasave: Blocks waiting for replication: 1
blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
{noformat}

"0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".

We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.


+1 patch looks good.

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi reassigned HADOOP-5780:
------------------------------------

    Assignee: Raghu Angadi

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5780:
---------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I just committed this.

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707191#action_12707191 ] 

Suresh Srinivas commented on HADOOP-5780:
-----------------------------------------

+1

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5780:
---------------------------------

    Attachment: HADOOP-5780.patch

attached patch would change the above message to : {noformat}
Metasave: Blocks waiting for replication: 1
blk_6735500019364591152_0 MISSING (replicas: l: 0 d: 0 c: 2 e: 0) 74.6.132.200:50010(corrupt) :  192.168.0.107:50010(corrupt) :
{noformat}

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>         Attachments: HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706690#action_12706690 ] 

Suresh Srinivas commented on HADOOP-5780:
-----------------------------------------

"decommisioned" has a typo. It should be "decommissioned".

Also not covered in the description - the patch includes additional useful information that identifies a block on a node as "corrupt" or "decommissioned".

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707106#action_12707106 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5780:
------------------------------------------------

(Didn't intend to change the issue description in the last comment.  Probably accidentally changed some invisible characters.  Sorry.)

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.20.0
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5780) Fix slightly confusing log from "-metaSave" on NameNode

Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghu Angadi updated HADOOP-5780:
---------------------------------

    Attachment: HADOOP-5780.patch

Updated patch for trunk. Earlier one does not apply to current trunk. 

> Fix slightly confusing log from "-metaSave" on NameNode
> -------------------------------------------------------
>
>                 Key: HADOOP-5780
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5780
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Raghu Angadi
>            Assignee: Raghu Angadi
>            Priority: Minor
>         Attachments: HADOOP-5780.patch, HADOOP-5780.patch
>
>
> After HADOOP-4103, "-metaSave" on NameNode prints "MISSING" in the line for a block that does not have any good replicas left. 
> e.g. : {noformat}
> Metasave: Blocks waiting for replication: 1
> blk_6735500019364591152_0 (replicas: l: 0 d: 0 c: 2 e: 0 MISSING) 74.6.132.200:50010 :  192.168.0.107:50010 :
> {noformat}
> "0 MISSING" in the log might imply to the user that there is no missing block, though it implies "e(xcess replicas) : 0".
> We should fix that. Also as part of this I would like to indicate which datanodes are decommissioned or contain the corrupt replicas.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.