[jira] [Commented] (FLINK-4562) table examples make an divided module in flink-examples

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861120#comment-15861120 ] 

ASF GitHub Bot commented on FLINK-4562:
---------------------------------------

Github user shijinkui commented on the issue:

    https://github.com/apache/flink/pull/2460
  
    > The repackaging is good.
    > Unfortunately this breaks the Table API tests, because they use one of the examples.
    > 
    > The Table API IT cases probably need to use their own programs, rather than relying on the examples.
    
    Table test dependency the `WC` case class of WordCountExample. I have divided them. 
    
    the flink-examples-table module have support building the fat jar like `flink-examples-streaming` and `flink-examples-batch`. IMO, all the example module should move to the `flink-examples` module as a sub-module :)
    



> table examples make an divided module in flink-examples
> -------------------------------------------------------
>
>                 Key: FLINK-4562
>                 URL: https://issues.apache.org/jira/browse/FLINK-4562
>             Project: Flink
>          Issue Type: Improvement
>          Components: Examples, Table API & SQL
>            Reporter: shijinkui
>            Assignee: shijinkui
>             Fix For: 1.2.1
>
>
> example code should't packaged in table module.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)