[GitHub] [accumulo] EdColeman commented on a diff in pull request #2964: fix #2955 - upgrade zk authorization check

[GitBox <gi...@apache.org>]

EdColeman commented on code in PR #2964:
URL: https://github.com/apache/accumulo/pull/2964#discussion_r980394958


##########
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java:
##########
@@ -162,6 +165,21 @@ private static String getFmtTime(final long epoch) {
     return fmt.format(timestamp);
   }
 
+  /**
+   * Get the ZooKeeper digest based on the instance secret that is used within ZooKeeper for
+   * authentication. This method is primary intended to be used to valid ZooKeeper ACLs. Use
+   * {@link #digestAuth(ZooKeeper, String)} to add authorizations to ZooKeeper.
+   */
+  public static Id getZkAuthId(final String secret) {

Review Comment:
   Addressed with e24e4d593f



##########
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooUtil.java:
##########
@@ -162,6 +165,21 @@ private static String getFmtTime(final long epoch) {
     return fmt.format(timestamp);
   }
 
+  /**
+   * Get the ZooKeeper digest based on the instance secret that is used within ZooKeeper for
+   * authentication. This method is primary intended to be used to valid ZooKeeper ACLs. Use

Review Comment:
   Addressed with e24e4d593f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org