You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "r-sidd (via GitHub)" <gi...@apache.org> on 2024/10/28 19:18:35 UTC
[PR] [FLINK-36617] migrate kyro package [flink]
r-sidd opened a new pull request, #25583:
URL: https://github.com/apache/flink/pull/25583
## What is the purpose of the change
Migrate kryo package
## Brief change log
Kryo has been moved to the com.esotericsoftware package. Updating to this version will enhance capabilities, ensure the dependency is up to date, and address vulnerabilities in the current dependencies, specifically [CVE-2020-15250](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250)
Package details: https://mvnrepository.com/artifact/com.esotericsoftware/kryo/4.0.3
Updating to version 4.0.3, as higher versions are causing local build failures.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: don't know
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2594998537
@r-sidd are you ok to close and pursue resolution via the Flip?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #25583: [FLINK-36617] migrate kyro package
URL: https://github.com/apache/flink/pull/25583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "tomncooper (via GitHub)" <gi...@apache.org>.
tomncooper commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2539442790
Looks like you have conflicting versions of `org.ow2.asm:asm`. You may need to override the transitive versions of kryo from other packages (in this case the one coming from `com.twitter:chill-java` in `flink-streaming-java`) in order to get the build to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2442469719
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd09f113b30403cb8b1407d716f75cc52feba208",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd09f113b30403cb8b1407d716f75cc52feba208",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd09f113b30403cb8b1407d716f75cc52feba208 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "nicknezis (via GitHub)" <gi...@apache.org>.
nicknezis commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2566708052
Yes. this seems to be a duplicate. I would propose closing it and deferring to the existing [FLIP-317](https://cwiki.apache.org/confluence/display/FLINK/FLIP-317%3A+Upgrade+Kryo+from+2.24.0+to+5.5.0) and #22660 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2888802394
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2811903807
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "r-sidd (via GitHub)" <gi...@apache.org>.
r-sidd commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2551906352
> Looks like you have conflicting versions of `org.ow2.asm:asm`. You may need to override the transitive versions of kryo from other packages (in this case the one coming from `com.twitter:chill-java` in `flink-streaming-java`) in order to get the build to work.
Hey thanks for the guidance, I'll try to make the necessary adjustments to get the build working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-36617] migrate kyro package [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #25583:
URL: https://github.com/apache/flink/pull/25583#issuecomment-2551919672
isn't it a duplicate of
https://github.com/apache/flink/pull/22660
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org