You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2025/09/02 18:23:38 UTC
(superset) branch 6.0 updated (5442521e18 -> d30cd5dc2a)
This is an automated email from the ASF dual-hosted git repository.
jli pushed a change to branch 6.0
in repository https://gitbox.apache.org/repos/asf/superset.git
from 5442521e18 fix: Athena quoting (#34895)
new 026e016720 fix(dashboard): table charts render correctly after tab switch and refresh (#34975)
new 714a03e007 fix(TimeTable): use type-only export for TableChartProps to resolve webpack warnings (#34989)
new d30cd5dc2a fix: playwright feature flag evaluation (#34978)
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../dashboard/components/gridComponents/Row.jsx | 6 ++
.../components/gridComponents/Row.test.jsx | 90 ++++++++++++++++++++++
.../src/visualizations/TimeTable/config/index.ts | 3 +-
.../TimeTable/config/transformProps/index.ts | 3 +-
superset/utils/webdriver.py | 15 +++-
5 files changed, 113 insertions(+), 4 deletions(-)
(superset) 03/03: fix: playwright feature flag evaluation (#34978)
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch 6.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit d30cd5dc2a36e64a57698d677c92201262caebbb
Author: Daniel Vaz Gaspar <da...@gmail.com>
AuthorDate: Tue Sep 2 18:44:22 2025 +0100
fix: playwright feature flag evaluation (#34978)
(cherry picked from commit b2f8803486aae4c5d1f6c0c2a889e0830c5c134a)
---
superset/utils/webdriver.py | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/superset/utils/webdriver.py b/superset/utils/webdriver.py
index 19770f0f99..746a784b93 100644
--- a/superset/utils/webdriver.py
+++ b/superset/utils/webdriver.py
@@ -38,7 +38,6 @@ from selenium.webdriver.remote.webdriver import WebDriver
from selenium.webdriver.support import expected_conditions as EC # noqa: N812
from selenium.webdriver.support.ui import WebDriverWait
-from superset import feature_flag_manager
from superset.extensions import machine_auth_provider_factory
from superset.utils.retries import retry_call
from superset.utils.screenshot_utils import take_tiled_screenshot
@@ -47,9 +46,11 @@ WindowSize = tuple[int, int]
logger = logging.getLogger(__name__)
if TYPE_CHECKING:
+ from typing import Any
+
from flask_appbuilder.security.sqla.models import User
-if feature_flag_manager.is_feature_enabled("PLAYWRIGHT_REPORTS_AND_THUMBNAILS"):
+try:
from playwright.sync_api import (
BrowserContext,
Error as PlaywrightError,
@@ -58,6 +59,16 @@ if feature_flag_manager.is_feature_enabled("PLAYWRIGHT_REPORTS_AND_THUMBNAILS"):
sync_playwright,
TimeoutError as PlaywrightTimeout,
)
+except ImportError:
+ from typing import Any
+
+ # Define dummy classes when playwright is not available
+ BrowserContext = Any
+ PlaywrightError = Exception
+ PlaywrightTimeout = Exception
+ Locator = Any
+ Page = Any
+ sync_playwright = None
class DashboardStandaloneMode(Enum):
(superset) 01/03: fix(dashboard): table charts render correctly after tab switch and refresh (#34975)
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch 6.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 026e01672037b31ae8c41f7b2a0cb293fc88e3de
Author: Gabriel Torres Ruiz <ga...@gmail.com>
AuthorDate: Tue Sep 2 14:29:42 2025 -0300
fix(dashboard): table charts render correctly after tab switch and refresh (#34975)
(cherry picked from commit 6a4b1df3a2f66863dc2b5894943654738bb08f0a)
---
.../dashboard/components/gridComponents/Row.jsx | 6 ++
.../components/gridComponents/Row.test.jsx | 90 ++++++++++++++++++++++
2 files changed, 96 insertions(+)
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
index 64fedfef15..61cd5ff69e 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Row.jsx
@@ -171,6 +171,7 @@ const Row = props => {
useEffect(() => {
let observerEnabler;
let observerDisabler;
+
if (
isFeatureEnabled(FeatureFlag.DashboardVirtualization) &&
!isCurrentUserBot()
@@ -179,12 +180,15 @@ const Row = props => {
([entry]) => {
if (entry.isIntersecting && isComponentVisibleRef.current) {
setIsInView(true);
+ } else if (!isComponentVisibleRef.current) {
+ setIsInView(false);
}
},
{
rootMargin: '100% 0px',
},
);
+
observerDisabler = new IntersectionObserver(
([entry]) => {
if (!entry.isIntersecting && isComponentVisibleRef.current) {
@@ -198,12 +202,14 @@ const Row = props => {
rootMargin: '400% 0px',
},
);
+
const element = containerRef.current;
if (element) {
observerEnabler.observe(element);
observerDisabler.observe(element);
}
}
+
return () => {
observerEnabler?.disconnect();
observerDisabler?.disconnect();
diff --git a/superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx b/superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx
index 1d7c4a39d2..e15d116f06 100644
--- a/superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx
+++ b/superset-frontend/src/dashboard/components/gridComponents/Row.test.jsx
@@ -27,6 +27,22 @@ import { getMockStore } from 'spec/fixtures/mockStore';
import { dashboardLayout as mockLayout } from 'spec/fixtures/mockDashboardLayout';
import { initialState } from 'src/SqlLab/fixtures';
+jest.mock('@superset-ui/core', () => ({
+ ...jest.requireActual('@superset-ui/core'),
+ isFeatureEnabled: jest.fn(() => true),
+ FeatureFlag: {
+ DashboardVirtualization: 'DASHBOARD_VIRTUALIZATION',
+ },
+}));
+
+jest.mock('src/utils/isBot', () => ({
+ isCurrentUserBot: jest.fn(() => false),
+}));
+
+jest.mock('src/dashboard/util/isEmbedded', () => ({
+ isEmbedded: jest.fn(() => false),
+}));
+
jest.mock('src/dashboard/components/dnd/DragDroppable', () => ({
Draggable: ({ children }) => (
<div data-test="mock-draggable">{children({})}</div>
@@ -185,3 +201,77 @@ test('should increment the depth of its children', () => {
`${props.depth + 1}`,
);
});
+
+describe('visibility handling for intersection observers', () => {
+ const mockIntersectionObserver = jest.fn();
+ const mockObserve = jest.fn();
+ const mockDisconnect = jest.fn();
+
+ beforeAll(() => {
+ mockIntersectionObserver.mockReturnValue({
+ observe: mockObserve,
+ unobserve: jest.fn(),
+ disconnect: mockDisconnect,
+ });
+ window.IntersectionObserver = mockIntersectionObserver;
+ });
+
+ beforeEach(() => {
+ jest.clearAllMocks();
+ });
+
+ afterAll(() => {
+ delete window.IntersectionObserver;
+ });
+
+ test('should handle visibility prop changes without crashing', () => {
+ const { rerender } = setup({ isComponentVisible: true });
+
+ expect(setup).not.toThrow();
+
+ expect(() => {
+ rerender(<Row {...props} isComponentVisible={false} />);
+ }).not.toThrow();
+
+ expect(() => {
+ rerender(<Row {...props} isComponentVisible />);
+ }).not.toThrow();
+ });
+
+ test('should create intersection observers when feature is enabled', () => {
+ setup({ isComponentVisible: true });
+
+ expect(mockIntersectionObserver).toHaveBeenCalledWith(
+ expect.any(Function),
+ expect.objectContaining({ rootMargin: expect.any(String) }),
+ );
+ });
+
+ test('should not create intersection observers when feature is disabled', () => {
+ const coreMock = jest.requireMock('@superset-ui/core');
+ coreMock.isFeatureEnabled.mockReturnValue(false);
+
+ jest.clearAllMocks();
+ setup({ isComponentVisible: true });
+
+ expect(mockIntersectionObserver).not.toHaveBeenCalled();
+
+ coreMock.isFeatureEnabled.mockReturnValue(true);
+ });
+
+ test('intersection observer callbacks handle entries without errors', () => {
+ const callback = ([entry]) => {
+ if (entry.isIntersecting) return true;
+
+ return false;
+ };
+
+ const intersectingEntry = { isIntersecting: true };
+ expect(() => callback([intersectingEntry])).not.toThrow();
+ expect(callback([intersectingEntry])).toBe(true);
+
+ const nonIntersectingEntry = { isIntersecting: false };
+ expect(() => callback([nonIntersectingEntry])).not.toThrow();
+ expect(callback([nonIntersectingEntry])).toBe(false);
+ });
+});
(superset) 02/03: fix(TimeTable): use type-only export for TableChartProps to resolve webpack warnings (#34989)
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jli pushed a commit to branch 6.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 714a03e007e8fb00ba1eb7af9a2ad2e142084796
Author: Gabriel Torres Ruiz <ga...@gmail.com>
AuthorDate: Tue Sep 2 14:43:51 2025 -0300
fix(TimeTable): use type-only export for TableChartProps to resolve webpack warnings (#34989)
(cherry picked from commit 744fa1f54c45fdc6be77ef5184d5848b4784ebf6)
---
superset-frontend/src/visualizations/TimeTable/config/index.ts | 3 ++-
.../src/visualizations/TimeTable/config/transformProps/index.ts | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/visualizations/TimeTable/config/index.ts b/superset-frontend/src/visualizations/TimeTable/config/index.ts
index 240aa55b74..40df84c44b 100644
--- a/superset-frontend/src/visualizations/TimeTable/config/index.ts
+++ b/superset-frontend/src/visualizations/TimeTable/config/index.ts
@@ -18,4 +18,5 @@
*/
export { controlPanel } from './controlPanel';
-export { transformProps, TableChartProps } from './transformProps';
+export { transformProps } from './transformProps';
+export type { TableChartProps } from './transformProps';
diff --git a/superset-frontend/src/visualizations/TimeTable/config/transformProps/index.ts b/superset-frontend/src/visualizations/TimeTable/config/transformProps/index.ts
index 93aa9bc28f..cc5c1bf1fb 100644
--- a/superset-frontend/src/visualizations/TimeTable/config/transformProps/index.ts
+++ b/superset-frontend/src/visualizations/TimeTable/config/transformProps/index.ts
@@ -17,4 +17,5 @@
* under the License.
*/
-export { transformProps, TableChartProps } from './transformProps';
+export { transformProps } from './transformProps';
+export type { TableChartProps } from './transformProps';