You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "davebarnes97 (GitHub)" <gi...@apache.org> on 2018/09/18 21:34:33 UTC

[GitHub] [geode-native] davebarnes97 opened pull request #356: Feature/geode 5751

Move 2 userguide source directories up one level in the directory tree.

../docs/geode-native-docs becomes ../geode-native-docs
../docs/geode-native-book becomes ../geode-native-book
../docs directory remains with other content (../docs/api and ../docs/docker)


[ Full content available at: https://github.com/apache/geode-native/pull/356 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] davebarnes97 closed pull request #356: GEODE-5751: Move 2 userguide source directories up one level in the directory tree.

Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
[ pull request closed by davebarnes97 ]

[ Full content available at: https://github.com/apache/geode-native/pull/356 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] igodwin commented on issue #356: Feature/geode 5751

Posted by "igodwin (GitHub)" <gi...@apache.org>.
The restructuring looks good, though I would ask that you rename the PR to match current convention.

[ Full content available at: https://github.com/apache/geode-native/pull/356 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] davebarnes97 commented on issue #356: GEODE-5751: Move 2 userguide source directories up one level in the directory tree.

Posted by "davebarnes97 (GitHub)" <gi...@apache.org>.
I agree with reviewer @mmartell - this directory change is really a workaround for an issue with bookbinder. As such, it's an imperfect and temporary solution.
I will withdraw this PR in favor of a more lasting fix to the tool itself.

[ Full content available at: https://github.com/apache/geode-native/pull/356 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org