You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/11/07 03:03:30 UTC
Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-920
https://issues.apache.org/jira/browse/AURORA-920
Repository: aurora
Description
-------
Remove SchedulerActive, replace with explicit services.
This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
Diffs
-----
src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 6, 2014, 6:06 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerActive.java, line 23
> > <https://reviews.apache.org/r/27716/diff/1/?file=754187#file754187line23>
> >
> > Replace with a meaningful doc, fix formatting.
Done.
> On Nov. 6, 2014, 6:06 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java, line 117
> > <https://reviews.apache.org/r/27716/diff/1/?file=754189#file754189line117>
> >
> > fill in doc
Done.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60287
-----------------------------------------------------------
On Nov. 6, 2014, 6:41 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 6:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> test_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60287
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/SchedulerActive.java
<https://reviews.apache.org/r/27716/#comment101652>
Replace with a meaningful doc, fix formatting.
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
<https://reviews.apache.org/r/27716/#comment101653>
fill in doc
- Bill Farner
On Nov. 7, 2014, 2:03 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60291
-----------------------------------------------------------
Ship it!
Master (5250a94) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 7, 2014, 2:03 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
> On Nov. 6, 2014, 6:34 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java, lines 64-69
> > <https://reviews.apache.org/r/27716/diff/1/?file=754191#file754191line64>
> >
> > The method is gone but the doc stays? If so, needs revisiting (@param).
good catch, dropped
> On Nov. 6, 2014, 6:34 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/SchedulerActive.java, line 29
> > <https://reviews.apache.org/r/27716/diff/1/?file=754187#file754187line29>
> >
> > Why not defining it inside of SchedulerLifecycle instead?
good idea, done.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60289
-----------------------------------------------------------
On Nov. 6, 2014, 6:41 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 6:41 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> test_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60289
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/SchedulerActive.java
<https://reviews.apache.org/r/27716/#comment101656>
Why not defining it inside of SchedulerLifecycle instead?
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java
<https://reviews.apache.org/r/27716/#comment101654>
The method is gone but the doc stays? If so, needs revisiting (@param).
- Maxim Khutornenko
On Nov. 7, 2014, 2:03 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 2:03 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60299
-----------------------------------------------------------
Master (5250a94) is red with this patch.
./build-support/jenkins/build.sh
+ date
Fri Nov 7 03:41:10 UTC 2014
+ ./gradlew -Pq clean build
:buildSrc:clean UP-TO-DATE
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift
:checkPython
:generateSources
:compileGeneratedJavaNote: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:assemble
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/SchedulerModule.java:42: Using the '.*' form of import should be avoided - org.apache.aurora.scheduler.SchedulerLifecycle.*.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/SchedulerModule.java:123: Line is longer than 100 characters (found 114).
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/SchedulerModule.java:129: Line is longer than 100 characters (found 119).
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 27.269 secs
- Aurora ReviewBot
On Nov. 7, 2014, 3:40 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 3:40 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> test_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60300
-----------------------------------------------------------
Ship it!
Master (5250a94) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 7, 2014, 3:46 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 3:46 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> test_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 7:46 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Appease buildbot.
Bugs: AURORA-920
https://issues.apache.org/jira/browse/AURORA-920
Repository: aurora
Description
-------
Remove SchedulerActive, replace with explicit services.
This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
Diffs (updated)
-----
src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing
-------
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 7:40 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Maxim and Bill's feedback.
Bugs: AURORA-920
https://issues.apache.org/jira/browse/AURORA-920
Repository: aurora
Description
-------
Remove SchedulerActive, replace with explicit services.
This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
Diffs (updated)
-----
src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing
-------
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/#review60293
-----------------------------------------------------------
Ship it!
Master (5250a94) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Nov. 7, 2014, 2:41 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27716/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2014, 2:41 a.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-920
> https://issues.apache.org/jira/browse/AURORA-920
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Remove SchedulerActive, replace with explicit services.
>
> This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
> src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
> src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
> src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
> src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
> src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
> src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
> src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
> src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
>
> Diff: https://reviews.apache.org/r/27716/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> test_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 6:41 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-920
https://issues.apache.org/jira/browse/AURORA-920
Repository: aurora
Description
-------
Remove SchedulerActive, replace with explicit services.
This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
Diffs
-----
src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing (updated)
-------
./gradlew -Pq build
test_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 27716: Remove SchedulerActive,
replace with explicit lifecycle.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27716/
-----------------------------------------------------------
(Updated Nov. 6, 2014, 6:40 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Fix JavaDoc.
Bugs: AURORA-920
https://issues.apache.org/jira/browse/AURORA-920
Repository: aurora
Description
-------
Remove SchedulerActive, replace with explicit services.
This is the first part of a larger change that will allow us to make pubsub events async as it makes the dependency on subscribers processing a SchedulerActive event explicit.
Diffs (updated)
-----
src/main/java/org/apache/aurora/GuavaUtils.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerActive.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 823ff75559e5155d851d599fd0cd311a03f39daa
src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 09c8bc93d95c7a82265730480747554512a0ffd4
src/main/java/org/apache/aurora/scheduler/TaskVars.java 3ebb8d0c96a13391438eab9e4b77bf152e9773fd
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 1d3978386299d823d9ce6e258760b2f21e48de83
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 10465ce54ec2446ce0dd85ec28ad433ebb7f7660
src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java e7fafec45e74008a4eac0787ed9c12b3ce81d4c0
src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java b5c8533bafbd13c73371ca1124036a11010e7c20
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 463a3aaffa18240c7d1cb83dfc67903baf2dd707
src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java d4d3a25cd9bc5dafce6ef1d6d3295f56b0b8a224
src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java e091ca39f4de43a285575e32ceaa7f1521cf67af
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42
src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 850c9a97df6e3c71bbdeef03fed30153a04b45d8
src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java c53cfe0bfb74a30b99e45b6303d6651cdc44bbdd
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8baec047a2e0436847ff4558c56428d9d4c2da5a
Diff: https://reviews.apache.org/r/27716/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Kevin Sweeney