You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2023/05/31 18:16:22 UTC
[GitHub] [netbeans] matthiasblaesing opened a new issue, #6004: X
matthiasblaesing opened a new issue, #6004:
URL: https://github.com/apache/netbeans/issues/6004
### Apache NetBeans version
Apache NetBeans 18 release candidate
### What happened
asfdsd
### How to reproduce
asfd
### Did this work correctly in an earlier version?
Apache NetBeans 15
### Operating System
asdf
### JDK
asdf
### Apache NetBeans packaging
Apache NetBeans provided installer, Apache NetBeans Snap Package, Third-party package
### Anything else
_No response_
### Are you willing to submit a pull request?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1572030019
OK, the culprit is ModuleManager:2199. I've consulted that with @jtulach and we come to conclusion that the Package dependency was originally meant as a test for system package. Otherwise it would require, at the point of this getProblems() test, to bring up classloaders for the entire subtree rooted at the tested module: this is both barely possible (as dependencies are not deep-discovered yet, entire `simulateEnable` uses depth-first traversal, and terrible performance.
If the check is disabled at this point (as it was earlier), module system might accept a module (which will be later rejected for missing required package) - and will load *all its dependencies*. While the broken module will not load in the final stage, all its dependencies will, recursively, even though they are not needed in the system. Those dependencies may register services, `-Provides` declarations etc, further polluting the module system.
In addition, NB prints an error on startup that a module cannot be enabled bcs. of missing dependency - and not only that: the failed module actually breaks the startup, if there's > 1 such module (one fallback is attempted).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1572691016
I think I have a straight story how JavaFX loading should work correctly, see referenced PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1570836149
I do wish we'd not rushed that one in after freeze. Cause of a few headaches. Third possible fix for an 18-u1?
Aside - you can use the task / meta form and relabel as a bug to bypass the main issue form, or even just use issues/new in the address bar - save emailing everyone the asdf. 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1571633541
We cannot revert the fix as it will mean JS is not loaded and proxy autodetection does not work again. JavaFX not loading is serious problem and needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1571273494
this might be related to #5955, since tests started to have issues loading javafx too. It seems to be a race condition though, success chance is fairly low.
I tried to revert the complete changeset of 5842 to run the platform tests in CI and check if that stabilizes the tests but it conflicts unfortunately (and have no time for this now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1571670801
@neilcsmith-net the possible fix should go to `release180`, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1570737422
@sdedic could you please have a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1571639064
Will try to fix. The additions in #5842 were actually in line with how the module system should behave (except the introduced bug), as package requirements did not work well in eagers + autoloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1571691273
@sdedic to master, then once verified, cherry picked in a separate PR to release180.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1570865281
Yeah sorry for the noise. I was mildly annoyed as this took me about 2-3 hours bisecting. Just read this in the PR cover letter:
> For autoload modules that provide tokens, the same check as for eager modules was added: this allows early detection of autoloads with unsatisfied java/package dependencies such as graalvm.sdk and 'javafx.linux`.
I think the issue that was overlooked here was, that on JDKs 11+ two modules are potentially required to be loaded together.
`org.netbeans.libs.javafx` is the base module, that is always required. On Oracle JDK 8 this module alone is enough as JavaFX is loaded from the `ext` directory (via the `Classpath` entry in the manifest). On JDK 11+ though one of the `org.netbeans.libs.javafx.<OS>` modules needs to be loaded. These modules are declared as fragments loaded into the host `org.netbeans.libs.javafx`. This special case (fragements) has to be considered when evaluating loading problems.
For OpenJFX we can ditch this with NB19, but NB18 should still support JDK 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1572565340
> We cannot revert the fix as it will mean JS is not loaded and proxy autodetection does not work again. JavaFX not loading is serious problem and needs to be fixed.
@MartinBalin just to clarify, I didn't want to propose to revert the PR on master, I only considered to revert it in a draft to check if the issue of the unreliable tests is connected to this issue here. Since in both cases javafx modules can't be loaded, but if restarted often enough, it sometimes works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on issue #6004: Loading OpenJFX broken after #5842
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on issue #6004:
URL: https://github.com/apache/netbeans/issues/6004#issuecomment-1572695916
@matthiasblaesing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing closed issue #6004: Loading OpenJFX broken after #5842
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed issue #6004: Loading OpenJFX broken after #5842
URL: https://github.com/apache/netbeans/issues/6004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists