[jira] [Comment Edited] (PDFBOX-2835) [PATCH] Make Overlay class properly extendable

["John Hewson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596302#comment-14596302 ] 

John Hewson edited comment on PDFBOX-2835 at 6/22/15 5:40 PM:
--------------------------------------------------------------

We prefer to add new APIs for new features rather than just making methods protected and having each user build his own API in a different manner. e.g. instead of allowing processPages(List<PDPages>) to be overridden we'd prefer to add getPages(PDDocument) which could be called by processPages, because that reduces protected API surface area.

What's the high level goal of this patch? The custom list of pages makes sense but I'm not sure why you'd want custom output methods? What's the BBox code for?


was (Author: jahewson):
We prefer to add new APIs for new features rather than just making methods protected and having each user build his own API in a different manner. e.g. instead of allowing processPages(List<PDPages>) to be overridden we'd prefer getPages(PDDocument) which could be called by processPages, because that reduces protected API surface area.

What's the high level goal of this patch? The custom list of pages makes sense but I'm not sure why you'd want custom output methods? What's the BBox code for?

> [PATCH] Make Overlay class properly extendable
> ----------------------------------------------
>
>                 Key: PDFBOX-2835
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-2835
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Utilities
>    Affects Versions: 1.8.9
>            Reporter: Igor Savin
>
> We are trying to implement custom logic for overlaying documents. However, current PDFBox implementation is excessively strictly encapsulated and it's not really possible. What makes things worse, overlay implementation is very strict about the way output gets processed. Please find attached link to the patch that makes overlay logic more flexible by:
> 1) Making some of the methods protected;
> 2) Moving output logic to a method that can be overridden.
> 3) Moving getting list of pages to be processed logic to a method that can be overridden.
> http://kiberion.net/kibertoad/0001-Modify-Overlay-class-for-improved-extensibility.patch
> If there are some adjustments that should be done or a separate version made for trunk - please let me know, I'll get to it immediately.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org