You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by medjessy <gi...@git.apache.org> on 2017/05/04 20:55:58 UTC

[GitHub] nifi pull request #1755: NIFI-528 add support to specify timeout in ExecuteP...

GitHub user medjessy opened a pull request:

    https://github.com/apache/nifi/pull/1755

    NIFI-528 add support to specify timeout in ExecuteProcess

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/medjessy/nifi NIFI-528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1755.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1755
    
----
commit 4e3bad0f14761409df4dbe70eb405270876222b7
Author: Djessy Menard <dm...@clockwork-solutions.com>
Date:   2017-05-04T18:31:56Z

    NIFI-528 add support to specify timeout in ExecuteProcess

commit 1ad592f730bbfd09fe4f3234dca01e42a14c3cfb
Author: Djessy Menard <dm...@clockwork-solutions.com>
Date:   2017-05-04T19:49:02Z

    NIFI-528 test ExecuteProcess timeout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1755: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:

    https://github.com/apache/nifi/pull/1755
  
    I wonder if this was done on Windows with the Git options not being set to "checkout w/ Windows line encoding, check in with Unix."


---

[GitHub] nifi issue #1755: NIFI-528 add support to specify timeout in ExecuteProcess

Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1755
  
    @medjessy - Thanks for submitting this PR.  The changes look larger than I would expect when comparing diffs.  There appear to be a number of whitespace changes that make it difficult to review the commits.  The GitHub UI presents the diffs as a 100% change (line endings?), but I also see what look like extraneous whitespace changes in IntelliJ.  Do the diffs look right to you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---