You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "aliakseimakarau (via GitHub)" <gi...@apache.org> on 2023/01/22 17:02:23 UTC
[GitHub] [arrow] aliakseimakarau opened a new pull request, #33828: arrow::internal::anonymous-namespace::LinuxParseCpuFlags
aliakseimakarau opened a new pull request, #33828:
URL: https://github.com/apache/arrow/pull/33828
Building at the s390x with the -Werror triggers an error: arrow/cpp/src/arrow/util/cpu_info.cc:155:3:
error: statement has no effect [-Werror=unused-value] (347a88f). This fix will add a default zero value to the array flag_mappings[].
Signed-off-by: Aliaksei Makarau <al...@ibm.com>
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `breaking-change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #33828: GH-33787: [C++] Suppress unused-value warning from LinuxParseCpuFlags() on s390x
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #33828:
URL: https://github.com/apache/arrow/pull/33828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33828: GH-33787: [C++] Suppress unused-value warning from LinuxParseCpuFlags() on s390x
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33828:
URL: https://github.com/apache/arrow/pull/33828#issuecomment-1401754602
Benchmark runs are scheduled for baseline = 408e9ce1407196a3d2d6962442467b6345e84e06 and contender = f3966acd8e675a1a4e52633258f0237be677f81c. f3966acd8e675a1a4e52633258f0237be677f81c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/1336c556fdef48a1ae73f4fc8284b953...38ecd14a05584886a417ed1231a86b8d/)
[Failed :arrow_down:1.05% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/33a49631c70a4f61bd248fa791ab30ec...d9f16e8fa04a4e998b36ca7195066fba/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7fa5602e965d49eba27d07dcbb156ebe...b198a336524c4c26aa1e41fc13fce47c/)
[Finished :arrow_down:0.12% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/fb59e6ac1cef4723954e33fc9752f36a...8a1047c9a9664623a9817a3668e06348/)
Buildkite builds:
[Finished] [`f3966acd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2253)
[Failed] [`f3966acd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2278)
[Failed] [`f3966acd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2248)
[Finished] [`f3966acd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2271)
[Finished] [`408e9ce1` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2252)
[Failed] [`408e9ce1` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2277)
[Failed] [`408e9ce1` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2247)
[Finished] [`408e9ce1` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2270)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org