You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Jochen Kemnade <ke...@gmail.com> on 2015/11/12 17:45:00 UTC
Re: Next steps for 5.4
Hi,
Am 29.10.2015 um 19:07 schrieb Jochen Kemnade:
> I'd really love to get the final release out this year, maybe even by
> the end of November if we're not receiving any blocker feedback and the
> docs are complete by then.
A little more than two weeks have passed since the RC release. There
seems to be little related response from the community, both positive
and negative, I hope that's because nobody encountered any major issues.
What do you think, should we wait much longer?
Does anyone have any blocker tasks for the final release? Who needs help
with anything?
The release notes should probably be reviewed and synced with
https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob_plain;f=54_RELEASE_NOTES.md;h=4f1cd54f0db81d0d8a0b6dc1f6b3d84f9d7a4a8c;hb=HEAD.
Any volunteers?
What else is left to do documentation-wise?
Jochen
Re: Next steps for 5.4
Posted by Bob Harner <bo...@gmail.com>.
No, the new error message is quite clear. It's just the one in RC-1 that is
misleading.
On Sun, Nov 15, 2015 at 12:31 PM, Jochen Kemnade <ke...@gmail.com> wrote:
> Bob,
>
> Bob Harner <bo...@gmail.com> schrieb am Sa., 14. Nov. 2015 um 02:45
> Uhr:
>
> > So Hotel Booking is now running 5.4-rc-1 at
> > http://tapestry-vm.apache.org:8080/hotels seemingly without problems.
> >
>
> Good to hear that. :-)
>
>
> > It wouldn't be too bad if the error message weren't misleading
> > (implying that it's the <t:form> that lacks the client side id) .
>
>
> Do you mean before or after
>
> https://github.com/apache/tapestry-5/commit/18ea654718212d4f65d98fb7a106bfbbecc34d47
> ?
> I thought the new message is quite clear. Do you have any suggestions how
> to improve it?
>
>
> > I don't know if that means generating another RC, though.
> >
>
> I don't think that there is a *need* to create another RC. If someone
> volunteered to do the work, it wouldn't do any harm though.
>
> Jochen
>
Re: Next steps for 5.4
Posted by Jochen Kemnade <ke...@gmail.com>.
Bob,
Bob Harner <bo...@gmail.com> schrieb am Sa., 14. Nov. 2015 um 02:45 Uhr:
> So Hotel Booking is now running 5.4-rc-1 at
> http://tapestry-vm.apache.org:8080/hotels seemingly without problems.
>
Good to hear that. :-)
> It wouldn't be too bad if the error message weren't misleading
> (implying that it's the <t:form> that lacks the client side id) .
Do you mean before or after
https://github.com/apache/tapestry-5/commit/18ea654718212d4f65d98fb7a106bfbbecc34d47?
I thought the new message is quite clear. Do you have any suggestions how
to improve it?
> I don't know if that means generating another RC, though.
>
I don't think that there is a *need* to create another RC. If someone
volunteered to do the work, it wouldn't do any harm though.
Jochen
Re: Next steps for 5.4
Posted by Bob Harner <bo...@gmail.com>.
Jochen,
You're right of course. Removing that <t:label> from Book.tml fixed the
issue. So Hotel Booking is now running 5.4-rc-1 at
http://tapestry-vm.apache.org:8080/hotels seemingly without problems.
I also found the same issue with another app of mine, and Chris P. and
Kalle K. also reported the same problem in TAP5-2509. So I think it's
apparently pretty common for people to have this construct in their TML
files. It wouldn't be too bad if the error message weren't misleading
(implying that it's the <t:form> that lacks the client side id) . I don't
know if that means generating another RC, though. Maybe we need some more
opinions on that.
On Thu, Nov 12, 2015 at 2:26 PM, Jochen Kemnade <ke...@gmail.com> wrote:
> Hi,
>
> Jochen Kemnade <ke...@gmail.com> schrieb am Do., 12. Nov. 2015 um
> 20:08 Uhr:
>
> > I was unable to use RC1 for my recent Hotel Booking app changes due to a
> >> bug that I believe you fixed just after the RC1 release (maybe
> >> TAP5-2500?).
> >> I think it was something about the <t:form> element failing if it didn't
> >> have a client-side ID, but I can't provide details at the moment. I need
> >> to
> >> try the latest nightly build.
> >>
> >
> > I'll try to run the app with RC-1 tomorrow, maybe we can find a
> > workaround. I'd like to avoid the hassle of creating and voting on
> another
> > RC if possible.
> >
>
> I had a quick look at he repository. I guess the problem is in
>
> https://github.com/bobharner/tapestry5-hotel-booking/blob/master/src/main/resources/com/tap5/hotelbooking/pages/Book.tml#L51
> where a
> t:label is linked to a t:radiogroup. The radiogroup does not render
> anything, so there is no clientId to put into the Label's for attribute.
> You could change that to a regular HTML label. See also TAP5-2509 and
>
> https://github.com/apache/tapestry-5/commit/18ea654718212d4f65d98fb7a106bfbbecc34d47
> .
> Maybe we should add a special case for RadioGroup inside Label as that
> seems to be a common use case.
>
> Jochen
>
Re: Next steps for 5.4
Posted by Jochen Kemnade <ke...@gmail.com>.
Hi,
Jochen Kemnade <ke...@gmail.com> schrieb am Do., 12. Nov. 2015 um
20:08 Uhr:
> I was unable to use RC1 for my recent Hotel Booking app changes due to a
>> bug that I believe you fixed just after the RC1 release (maybe
>> TAP5-2500?).
>> I think it was something about the <t:form> element failing if it didn't
>> have a client-side ID, but I can't provide details at the moment. I need
>> to
>> try the latest nightly build.
>>
>
> I'll try to run the app with RC-1 tomorrow, maybe we can find a
> workaround. I'd like to avoid the hassle of creating and voting on another
> RC if possible.
>
I had a quick look at he repository. I guess the problem is in
https://github.com/bobharner/tapestry5-hotel-booking/blob/master/src/main/resources/com/tap5/hotelbooking/pages/Book.tml#L51
where a
t:label is linked to a t:radiogroup. The radiogroup does not render
anything, so there is no clientId to put into the Label's for attribute.
You could change that to a regular HTML label. See also TAP5-2509 and
https://github.com/apache/tapestry-5/commit/18ea654718212d4f65d98fb7a106bfbbecc34d47.
Maybe we should add a special case for RadioGroup inside Label as that
seems to be a common use case.
Jochen
Re: Next steps for 5.4
Posted by Jochen Kemnade <ke...@gmail.com>.
Bob,
Bob Harner <bo...@gmail.com> schrieb am Do., 12. Nov. 2015 um 19:48 Uhr:
> I may have time to review the release notes in a couple days if nobody
> beats me to it.
>
Great, thanks!
> Documentation-wise, I think the big shortcoming at the moment is better
> docs for all the new JavaScript capabilities.
> https://tapestry.apache.org/client-side-javascript.html is all background
> material, not a how-to guide.
> https://tapestry.apache.org/javascript-modules.html is better, but still
> not the practical, example-rich guide that I want to see.
>
Although I'd rather leave it to someone who is better at writing
documentation, especially in Engligh, I can try to have a look at that in
the next days. What do you have in mind in particular? I can definitely
contribute some code snippets if you like.
> I was unable to use RC1 for my recent Hotel Booking app changes due to a
> bug that I believe you fixed just after the RC1 release (maybe TAP5-2500?).
> I think it was something about the <t:form> element failing if it didn't
> have a client-side ID, but I can't provide details at the moment. I need to
> try the latest nightly build.
>
I'll try to run the app with RC-1 tomorrow, maybe we can find a workaround.
I'd like to avoid the hassle of creating and voting on another RC if
possible.
> Off topic, but... nightly snapshots at
>
> https://repository.apache.org/content/repositories/snapshots/org/apache/tapestry/tapestry-core/
> are very old. Is there another location?
>
Nightly builds were disabled because Apache changed the way they have to be
published. I believe Howard wrote an e-mail about that but I can't find it
right now.
Jochen
>
> On Thu, Nov 12, 2015 at 11:45 AM, Jochen Kemnade <ke...@gmail.com>
> wrote:
>
> > Hi,
> >
> > Am 29.10.2015 um 19:07 schrieb Jochen Kemnade:
> > > I'd really love to get the final release out this year, maybe even by
> > > the end of November if we're not receiving any blocker feedback and the
> > > docs are complete by then.
> >
> > A little more than two weeks have passed since the RC release. There
> > seems to be little related response from the community, both positive
> > and negative, I hope that's because nobody encountered any major issues.
> > What do you think, should we wait much longer?
> >
> > Does anyone have any blocker tasks for the final release? Who needs help
> > with anything?
> >
> > The release notes should probably be reviewed and synced with
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob_plain;f=54_RELEASE_NOTES.md;h=4f1cd54f0db81d0d8a0b6dc1f6b3d84f9d7a4a8c;hb=HEAD
> > .
> > Any volunteers?
> >
> > What else is left to do documentation-wise?
> >
> > Jochen
> >
> >
>
Re: Next steps for 5.4
Posted by Bob Harner <bo...@gmail.com>.
Jochen,
I may have time to review the release notes in a couple days if nobody
beats me to it.
Documentation-wise, I think the big shortcoming at the moment is better
docs for all the new JavaScript capabilities.
https://tapestry.apache.org/client-side-javascript.html is all background
material, not a how-to guide.
https://tapestry.apache.org/javascript-modules.html is better, but still
not the practical, example-rich guide that I want to see.
I was unable to use RC1 for my recent Hotel Booking app changes due to a
bug that I believe you fixed just after the RC1 release (maybe TAP5-2500?).
I think it was something about the <t:form> element failing if it didn't
have a client-side ID, but I can't provide details at the moment. I need to
try the latest nightly build.
Off topic, but... nightly snapshots at
https://repository.apache.org/content/repositories/snapshots/org/apache/tapestry/tapestry-core/
are very old. Is there another location?
On Thu, Nov 12, 2015 at 11:45 AM, Jochen Kemnade <ke...@gmail.com> wrote:
> Hi,
>
> Am 29.10.2015 um 19:07 schrieb Jochen Kemnade:
> > I'd really love to get the final release out this year, maybe even by
> > the end of November if we're not receiving any blocker feedback and the
> > docs are complete by then.
>
> A little more than two weeks have passed since the RC release. There
> seems to be little related response from the community, both positive
> and negative, I hope that's because nobody encountered any major issues.
> What do you think, should we wait much longer?
>
> Does anyone have any blocker tasks for the final release? Who needs help
> with anything?
>
> The release notes should probably be reviewed and synced with
>
> https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob_plain;f=54_RELEASE_NOTES.md;h=4f1cd54f0db81d0d8a0b6dc1f6b3d84f9d7a4a8c;hb=HEAD
> .
> Any volunteers?
>
> What else is left to do documentation-wise?
>
> Jochen
>
>
Re: Next steps for 5.4
Posted by Jochen Kemnade <jo...@eddyson.de>.
Am 14.12.2015 um 23:53 schrieb Kalle Korhonen:
> If we collectively think we are more or less ready, we should produce a
> final release build to be voted upon.
I'll try to do that tonight.
> We may want to see if Vangel's "problem when *add* a column to a
> *grid*" is a regression issue and perhaps address it.
I read about that on the users' list but I guess we need more
information to be able to reproduce it and find the cause.
Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Next steps for 5.4
Posted by Kalle Korhonen <ka...@gmail.com>.
On Mon, Dec 14, 2015 at 6:15 AM, Jochen Kemnade <jo...@eddyson.de>
wrote:
> Am 14.12.2015 um 15:07 schrieb Thiago H de Paula Figueiredo:
>
>> any thoughts on how we should continue?
>>> In my opinion there's nothing code-wise that's blocking the release.
>>>
>> +1
>>
> So, what do you suggest? Should we create a release build to be voted
> upon? Do we want to address all remaining documentation issues afterward?
> Or do we want another RC?
> I'm really unsure about the whole process and I'd really appreciate if
> someone who has more experience with releases in Apache projects could lend
> a hand.
If we collectively think we are more or less ready, we should produce a
final release build to be voted upon. There's no "Apache process" to
follow, it's whatever the project decides on. And it's simple to roll a new
patch release if we find some breaking things. I don't think we should wait
for all the remaining documentation issues. We may want to see if Vangel's
"problem when *add* a column to a *grid*" is a regression issue and perhaps
address it. I also had one other thing I just thought of (there's always
one...) that I'd like to get in but that said, we should not break for
non-critical issues.
Kalle
Re: Next steps for 5.4
Posted by Jochen Kemnade <jo...@eddyson.de>.
Hi,
Am 14.12.2015 um 15:07 schrieb Thiago H de Paula Figueiredo:
>> any thoughts on how we should continue?
>> In my opinion there's nothing code-wise that's blocking the release.
>
> +1
So, what do you suggest? Should we create a release build to be voted
upon? Do we want to address all remaining documentation issues
afterward? Or do we want another RC?
I'm really unsure about the whole process and I'd really appreciate if
someone who has more experience with releases in Apache projects could
lend a hand.
Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Next steps for 5.4
Posted by Thiago H de Paula Figueiredo <th...@gmail.com>.
On Mon, 14 Dec 2015 11:45:21 -0200, Jochen Kemnade
<jo...@eddyson.de> wrote:
> Hi,
Hi!
> any thoughts on how we should continue?
> In my opinion there's nothing code-wise that's blocking the release.
+1
--
Thiago H. de Paula Figueiredo
Tapestry, Java and Hibernate consultant and developer
http://machina.com.br
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: Next steps for 5.4
Posted by Jochen Kemnade <jo...@eddyson.de>.
Hi,
any thoughts on how we should continue?
In my opinion there's nothing code-wise that's blocking the release.
Jochen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org