You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sis.apache.org by GitBox <gi...@apache.org> on 2022/05/24 08:55:54 UTC
[GitHub] [sis] alexismanin opened a new pull request, #27: Fix/sql temporal
alexismanin opened a new pull request, #27:
URL: https://github.com/apache/sis/pull/27
@desruisseaux I'd like your review please (still cannot assign pull request to you).
PR content:
* added tests upon date/time conversion from sql to java types.
* Changed output API of date conversion from java.sql.Date to java.time.LocalDate
* Fix timezone management for `TIME WITH TIMEZONE` and `TIMESTAMP WITH TIMEZONE` sql types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sis] asfgit merged pull request #27: Fix/sql temporal
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit merged PR #27:
URL: https://github.com/apache/sis/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sis] desruisseaux commented on pull request #27: Fix/sql temporal
Posted by "desruisseaux (via GitHub)" <gi...@apache.org>.
desruisseaux commented on PR #27:
URL: https://github.com/apache/sis/pull/27#issuecomment-1448016862
Will apply this pull request with one amendment. This pull request changes the `TIMESTAMP_WITH_TIMEZONE` mapping from `java.time.OffsetDateTime` to `java.time.Instant`. I propose to keep the previous `OffsetDataTime`. Some searches on internet suggest that this mapping is part of JDBC 4.2 specification:
* [JDBC Maintenance Release 4.2](https://jcp.org/aboutJava/communityprocess/maintenance/jsr221/JDBC4.2MR-January2014.pdf)
* [Using Java 8 Date and Time classes in PostgreSQL](https://jdbc.postgresql.org/documentation/query/#using-java-8-date-and-time-classes)
* [Mapping between PostgreSQL and Java date/time types](https://tada.github.io/pljava/use/datetime.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org