[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2689: NO-JIRA Test Improvements

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2689: NO-JIRA Test Improvements
URL: https://github.com/apache/activemq-artemis/pull/2689#discussion_r289517546
 
 

 ##########
 File path: artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java
 ##########
 @@ -174,6 +175,9 @@
    @Rule
    public CleanupSystemPropertiesRule propertiesRule = new CleanupSystemPropertiesRule();
 
+   @Rule
+   public PortCheckRule portCheckRule = new PortCheckRule(61616, 61617, 61618);
 
 Review comment:
   @michaelandrepearce 61616 is the broker default port, right? We already have such validations on the testsuite. Refactoring to find a free port would be a way too heavy refactoring that I'm not ready to do. (thousands of tests).
   
   Besides it's sane to have such rules anyways.
   
   This is to validate if the broker is not leaked. I was dealing with a specific failure on my CI here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services