You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/09 00:45:54 UTC
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request
#5112: Support remove schema dynamically#step 3
menghaoranss opened a new pull request #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112
For #5065 .
Changes proposed in this pull request:
- Add a button to remove schemas in sharding-ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5112: Support remove schema dynamically#step 3
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112#discussion_r405902562
##########
File path: shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/ShardingSchemaService.java
##########
@@ -71,4 +71,11 @@
* @param dataSourceConfiguration data source configuration
*/
void addSchemaConfiguration(String schemaName, String ruleConfiguration, String dataSourceConfiguration);
+
+ /**
+ * Delete schema configuration.
+ *
+ * @param schemaName schema name
+ */
+ void deleteSchemaConfiguration(String schemaName);
Review comment:
deleteSchema is ok,
AddSchemaConfiguration means add schema from configuration parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5112:
Support remove schema dynamically#step 3
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112#issuecomment-611281935
## Pull Request Test Coverage Report for [Build 10917](https://coveralls.io/builds/29955624)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.218%**
---
| Totals | [](https://coveralls.io/builds/29955624) |
| :-- | --: |
| Change from base [Build 10916](https://coveralls.io/builds/29941958): | 0.0% |
| Covered Lines: | 11680 |
| Relevant Lines: | 20413 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5112:
Support remove schema dynamically#step 3
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5112:
Support remove schema dynamically#step 3
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112#issuecomment-611280404
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=h1) Report
> Merging [#5112](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/056817fe959af58b9fc5af44f3360f1223ed3424&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5112 +/- ##
=========================================
Coverage 53.81% 53.81%
Complexity 397 397
=========================================
Files 1148 1148
Lines 20413 20413
Branches 3688 3688
=========================================
Hits 10985 10985
Misses 8746 8746
Partials 682 682
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=footer). Last update [056817f...3b6a629](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5112?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5112: Support remove schema dynamically#step 3
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5112: Support remove schema dynamically#step 3
URL: https://github.com/apache/incubator-shardingsphere/pull/5112#discussion_r405902562
##########
File path: shardingsphere-ui/shardingsphere-ui-backend/src/main/java/org/apache/shardingsphere/ui/servcie/ShardingSchemaService.java
##########
@@ -71,4 +71,11 @@
* @param dataSourceConfiguration data source configuration
*/
void addSchemaConfiguration(String schemaName, String ruleConfiguration, String dataSourceConfiguration);
+
+ /**
+ * Delete schema configuration.
+ *
+ * @param schemaName schema name
+ */
+ void deleteSchemaConfiguration(String schemaName);
Review comment:
deleteSchema is ok,
AddSchemaConfiguration means add schema from configuration parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services