You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by wuchong <gi...@git.apache.org> on 2017/07/18 02:14:52 UTC

[GitHub] flink pull request #4128: [FLINK-6893][table]Add BIN supported in SQL

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4128#discussion_r127868400
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala ---
    @@ -33,6 +33,14 @@ object ScalarSqlFunctions {
         OperandTypes.NILADIC,
         SqlFunctionCategory.NUMERIC)
     
    +  val BIN = new SqlFunction(
    +    "BIN",
    +    SqlKind.OTHER_FUNCTION,
    +    ReturnTypes.explicit(SqlTypeName.VARCHAR),
    +    null,
    +    OperandTypes.NUMERIC,
    --- End diff --
    
    I don't think BIN accepts all NUMERIC operands. I think it only accepts BIGINT, TINYINT, SMALLINT,INTEGER.  And not support other decimal numeric. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---