You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chunhui shen (JIRA)" <ji...@apache.org> on 2012/09/19 10:27:07 UTC
[jira] [Created] (HBASE-6839) Operations may be executed without
rowLock
chunhui shen created HBASE-6839:
-----------------------------------
Summary: Operations may be executed without rowLock
Key: HBASE-6839
URL: https://issues.apache.org/jira/browse/HBASE-6839
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: chunhui shen
Assignee: chunhui shen
Priority: Critical
Fix For: 0.96.0
HRegion#internalObtainRowLock will return null if timed out,
but many place which call this method don't handle this case
The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-6839) Operations may be executed
without rowLock
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459291#comment-13459291 ]
Ted Yu edited comment on HBASE-6839 at 9/20/12 1:05 PM:
--------------------------------------------------------
@ram
obtainRowLock may return null
but in the increment, delete,append, we won't handle the null case,
and the result is operations is executed, but finally throw NPE when release row lock
{code}
2012-09-17 13:51:22,300 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer:
java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:922)
at org.apache.hadoop.hbase.regionserver.HRegion.releaseRowLock(HRegion.java:2522)
at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1668)
at org.apache.hadoop.hbase.regionserver.HRegionServer.put(HRegionServer.java:2075)
at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:603)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1348)
{code}
was (Author: zjushch):
@ram
obtainRowLock may return null
but in the increment, delete,append, we won't handle the null case,
and the result is operations is executed, but finally throw NPE when release row lock
{2012-09-17 13:51:22,300 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer:
java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:922)
at org.apache.hadoop.hbase.regionserver.HRegion.releaseRowLock(HRegion.java:2522)
at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1668)
at org.apache.hadoop.hbase.regionserver.HRegionServer.put(HRegionServer.java:2075)
at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:603)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1348)
}
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6839) Operations may be executed without
rowLock
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6839:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.2
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed trunk and 0.94 branch. Thanks for the patch Chunhui.
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459530#comment-13459530 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #183 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/183/])
HBASE-6839 Operations may be executed without rowLock (Revision 1387863)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469875#comment-13469875 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #8 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/8/])
HBASE-6839 Operations may be executed without rowLock (Revision 1387864)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.92.3, 0.94.2, 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459419#comment-13459419 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-0.94 #475 (See [https://builds.apache.org/job/HBase-0.94/475/])
HBASE-6839 Operations may be executed without rowLock (Revision 1387864)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459292#comment-13459292 ]
chunhui shen commented on HBASE-6839:
-------------------------------------
Sorry for forgeting to format the log....
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460758#comment-13460758 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-0.94-security #53 (See [https://builds.apache.org/job/HBase-0.94-security/53/])
HBASE-6839 Operations may be executed without rowLock (Revision 1387864)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.92.3, 0.94.2, 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459650#comment-13459650 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-0.92 #582 (See [https://builds.apache.org/job/HBase-0.92/582/])
HBASE-6839 correct variable name : mutation should be put (Revision 1388009)
HBASE-6839 Operations may be executed without holding rowLock (Chunhui) (Revision 1388004)
Result = SUCCESS
tedyu :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
tedyu :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6839:
--------------------------
Summary: Operations may be executed without holding rowLock (was: Operations may be executed without rowLock)
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458988#comment-13458988 ]
ramkrishna.s.vasudevan commented on HBASE-6839:
-----------------------------------------------
@Chunhui
doMiniBatchMutation is fine right.. Only increment, delete,append has this problem?
+1 on patch.
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459396#comment-13459396 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-TRUNK #3358 (See [https://builds.apache.org/job/HBase-TRUNK/3358/])
HBASE-6839 Operations may be executed without rowLock (Revision 1387863)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459291#comment-13459291 ]
chunhui shen commented on HBASE-6839:
-------------------------------------
@ram
obtainRowLock may return null
but in the increment, delete,append, we won't handle the null case,
and the result is operations is executed, but finally throw NPE when release row lock
{2012-09-17 13:51:22,300 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer:
java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap.remove(ConcurrentHashMap.java:922)
at org.apache.hadoop.hbase.regionserver.HRegion.releaseRowLock(HRegion.java:2522)
at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1668)
at org.apache.hadoop.hbase.regionserver.HRegionServer.put(HRegionServer.java:2075)
at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:603)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1348)
}
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459546#comment-13459546 ]
ramkrishna.s.vasudevan commented on HBASE-6839:
-----------------------------------------------
Nice one Chunhui.
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469991#comment-13469991 ]
Hudson commented on HBASE-6839:
-------------------------------
Integrated in HBase-0.92-security #143 (See [https://builds.apache.org/job/HBase-0.92-security/143/])
HBASE-6839 correct variable name : mutation should be put (Revision 1388009)
HBASE-6839 Operations may be executed without holding rowLock (Chunhui) (Revision 1388004)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
tedyu :
Files :
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.92.3, 0.94.2, 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-6839:
--------------------------------------
Fix Version/s: 0.92.3
Adding 0.92.3 as a target since Ted committed it there.
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.92.3, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6839) Operations may be executed without
rowLock
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-6839:
--------------------------
Status: Patch Available (was: Open)
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458893#comment-13458893 ]
stack commented on HBASE-6839:
------------------------------
+1
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
holding rowLock
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459578#comment-13459578 ]
Ted Yu commented on HBASE-6839:
-------------------------------
Integrated to 0.92 as well.
Thanks, Chunhui.
> Operations may be executed without holding rowLock
> --------------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6839) Operations may be executed without
rowLock
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458887#comment-13458887 ]
Hadoop QA commented on HBASE-6839:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545695/HBASE-6839.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
-1 javadoc. The javadoc tool appears to have generated 139 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2897//console
This message is automatically generated.
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6839) Operations may be executed without
rowLock
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-6839:
--------------------------------
Attachment: HBASE-6839.patch
In the patch, if timeout when obtain the row lock, then throws an IOException.
Another way to fix this case is no timeout for obtaining row lock, block until obtained...
> Operations may be executed without rowLock
> ------------------------------------------
>
> Key: HBASE-6839
> URL: https://issues.apache.org/jira/browse/HBASE-6839
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-6839.patch
>
>
> HRegion#internalObtainRowLock will return null if timed out,
> but many place which call this method don't handle this case
> The bad result is operation will be executed even if it havn't obtained the row lock. Such as put、delete、increment。。。
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira