You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bartek Plotka <bw...@gmail.com> on 2015/12/07 18:06:33 UTC
Review Request 41042: Added description of the LoadQoSController in
the oversubscritpion.md
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/
-----------------------------------------------------------
Review request for mesos, Niklas Nielsen and Vinod Kone.
Bugs: MESOS-4076
https://issues.apache.org/jira/browse/MESOS-4076
Repository: mesos
Description
-------
Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
Diffs (updated)
-----
docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
Diff: https://reviews.apache.org/r/41042/diff/
Testing
-------
Thanks,
Bartek Plotka
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109256
-----------------------------------------------------------
Bad patch!
Reviews applied: [40617]
Failed command: ./support/apply-review.sh -n -r 40617
Error:
2015-12-08 02:40:27 URL:https://reviews.apache.org/r/40617/diff/raw/ [16256/16256] -> "40617.patch" [1]
Successfully applied: Added Load QoS Controller for simple eviction when system load is above configured threshold.
Added Load QoS Controller for the simple eviction when system load is above configured system load threshold for 5min and 15min:
- Made os::loadavg called from the lambda and passed via the contructor.
- Added unit test.
Review: https://reviews.apache.org/r/40617
src/slave/qos_controllers/load.cpp:1: A license header should appear on the file's first line starting with '// Licensed'.: /**
Total errors found: 1
Checking 3 files
Failed to commit patch
- Mesos ReviewBot
On Dec. 7, 2015, 5:18 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 5:18 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109343
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40617, 41042]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 1:24 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 4, 2016, 6:35 p.m., Vinod Kone wrote:
> > docs/oversubscription.md, line 204
> > <https://reviews.apache.org/r/41042/diff/2/?file=1155933#file1155933line204>
> >
> > s/controller/the `load` qos controller/
s/controller/, the load qos controller/?
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------
On 十二月 8, 2015, 1:24 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated 十二月 8, 2015, 1:24 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Bartek Plotka <bw...@gmail.com>.
> On Jan. 4, 2016, 6:35 p.m., Vinod Kone wrote:
> > docs/oversubscription.md, line 204
> > <https://reviews.apache.org/r/41042/diff/2/?file=1155933#file1155933line204>
> >
> > s/controller/the `load` qos controller/
>
> Guangya Liu wrote:
> s/controller/, the load qos controller/?
@Guangya Liu: Agree (https://www.ego4u.com/en/cram-up/writing/comma?10)
- Bartek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------
On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 1:24 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112612
-----------------------------------------------------------
docs/oversubscription.md (line 202)
<https://reviews.apache.org/r/41042/#comment173119>
s/is ensuring/ensures/
docs/oversubscription.md (line 203)
<https://reviews.apache.org/r/41042/#comment173120>
s/a configurable/configurable/
docs/oversubscription.md (line 204)
<https://reviews.apache.org/r/41042/#comment173121>
s/controller/the `load` qos controller/
docs/oversubscription.md (line 333)
<https://reviews.apache.org/r/41042/#comment173122>
s/will be/is/
docs/oversubscription.md (line 334)
<https://reviews.apache.org/r/41042/#comment173123>
s/will be/is/
s/then slave/the agent/
- Vinod Kone
On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 1:24 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112850
-----------------------------------------------------------
Bad patch!
Reviews applied: [40617]
Failed command: ./support/apply-review.sh -n -r 40617
Error:
2016-01-05 14:20:00 URL:https://reviews.apache.org/r/40617/diff/raw/ [15675/15675] -> "40617.patch" [1]
error: patch failed: src/Makefile.am:1597
error: src/Makefile.am: patch does not apply
error: src/slave/qos_controllers/load.hpp: already exists in index
error: src/slave/qos_controllers/load.cpp: already exists in index
error: patch failed: src/tests/oversubscription_tests.cpp:43
error: src/tests/oversubscription_tests.cpp: patch does not apply
- Mesos ReviewBot
On Jan. 5, 2016, 10:41 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 10:41 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review112831
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 一月 5, 2016, 10:41 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated 一月 5, 2016, 10:41 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 10:41 a.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Changes
-------
Addressed issues.
Bugs: MESOS-4076
https://issues.apache.org/jira/browse/MESOS-4076
Repository: mesos
Description
-------
Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
Diffs (updated)
-----
docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
Diff: https://reviews.apache.org/r/41042/diff/
Testing
-------
Thanks,
Bartek Plotka
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 1:24 p.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Changes
-------
Issues addressed.
Bugs: MESOS-4076
https://issues.apache.org/jira/browse/MESOS-4076
Repository: mesos
Description
-------
Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
Diffs (updated)
-----
docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
Diff: https://reviews.apache.org/r/41042/diff/
Testing
-------
Thanks,
Bartek Plotka
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Bartek Plotka <bw...@gmail.com>.
> On Dec. 7, 2015, 5:24 p.m., Niklas Nielsen wrote:
> > docs/oversubscription.md, line 203
> > <https://reviews.apache.org/r/41042/diff/1/?file=1155191#file1155191line203>
> >
> > It comes as a module parameter, right? That can live in a file as well.
The same sentence was for fixed resource estimator (:
- Bartek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109167
-----------------------------------------------------------
On Dec. 8, 2015, 1:24 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2015, 1:24 p.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/#review109167
-----------------------------------------------------------
Ship it!
docs/oversubscription.md (line 201)
<https://reviews.apache.org/r/41042/#comment168630>
s/QoS/quality of service for regular tasks/ or something in the manner :)
docs/oversubscription.md (line 202)
<https://reviews.apache.org/r/41042/#comment168631>
How do you 'perform' QoS? :) It's ensuring the total system load doesn't exceed a threshold and thereby, simplistically, try to avoid cpu congestion.
docs/oversubscription.md (line 203)
<https://reviews.apache.org/r/41042/#comment168632>
It comes as a module parameter, right? That can live in a file as well.
docs/oversubscription.md (line 316)
<https://reviews.apache.org/r/41042/#comment168635>
We should maybe describe that these are standard unix load averages.
docs/oversubscription.md (line 329)
<https://reviews.apache.org/r/41042/#comment168633>
Let's expand to s/5min/5 minutes/
docs/oversubscription.md (line 330)
<https://reviews.apache.org/r/41042/#comment168634>
Same here for 15min
- Niklas Nielsen
On Dec. 7, 2015, 9:18 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41042/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2015, 9:18 a.m.)
>
>
> Review request for mesos, Niklas Nielsen and Vinod Kone.
>
>
> Bugs: MESOS-4076
> https://issues.apache.org/jira/browse/MESOS-4076
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
>
>
> Diffs
> -----
>
> docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
>
> Diff: https://reviews.apache.org/r/41042/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 41042: Added description of the LoadQoSController
in the oversubscription.md
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41042/
-----------------------------------------------------------
(Updated Dec. 7, 2015, 9:18 a.m.)
Review request for mesos, Niklas Nielsen and Vinod Kone.
Summary (updated)
-----------------
Added description of the LoadQoSController in the oversubscription.md
Bugs: MESOS-4076
https://issues.apache.org/jira/browse/MESOS-4076
Repository: mesos
Description
-------
Added description to _Writing a custom QoS controller_ and _Configuring oversubscription_ sections.
Diffs
-----
docs/oversubscription.md 7d1415a712f818f7664ed8322ddcdc57d3a1fb1f
Diff: https://reviews.apache.org/r/41042/diff/
Testing
-------
Thanks,
Bartek Plotka