You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/14 09:49:57 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31180: [SPARK-33354][FOLLOWUP][DOC] Shorten the table width of ANSI compliance casting document

HyukjinKwon commented on a change in pull request #31180:
URL: https://github.com/apache/spark/pull/31180#discussion_r557268509



##########
File path: docs/sql-ref-ansi-compliance.md
##########
@@ -69,19 +69,19 @@ The type conversion of Spark ANSI mode follows the syntax rules of section 6.13
 
  The valid combinations of target data type and source data type in a `CAST` expression are given by the following table.
 “Y” indicates that the combination is syntactically valid without restriction and “N” indicates that the combination is not valid.
-    
-| From\To   | NumericType | StringType | DateType | TimestampType | IntervalType | BooleanType | BinaryType | ArrayType | MapType | StructType |
+
+| Source\Target | Numeric | String | Date | Timestamp | Interval | Boolean | Binary | Array | Map | Struct |

Review comment:
       We could even make it lower-cased and say these are simple strings or catalog strings .. but I think it's fine either way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org