You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by sijie <gi...@git.apache.org> on 2017/06/01 20:58:49 UTC

[GitHub] bookkeeper pull request #178: BOOKKEEPER-1088: Ledger Recovery - Add a ReadE...

GitHub user sijie opened a pull request:

    https://github.com/apache/bookkeeper/pull/178

    BOOKKEEPER-1088: Ledger Recovery - Add a ReadEntryListener to callback on individual request

    THIS CHANGE IS BASED ON #177  (you can review 868a3c8 for the only change that belongs to BOOKKEEPER-1088).
    
    bookkeeper recovery improvement (part-3): add a ReadEntryListener to callback on individual request.
    
    - add read entry listener which allow doing batch read, but callback on individual entries in sequence. so in recovery op, we could issue batch reads, then on each individual callback do add entry and stop when received NoSuchEntry.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sijie/bookkeeper recovery_improvements_part3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 3db0b84570dec166855c70105a5cbf6f2ec14ea2
Author: Sijie Guo <si...@twitter.com>
Date:   2014-01-21T00:42:28Z

    bookkeeper recovery improvement (part-1): refactor PendingReadOp
    
    this change is the first part of improving bookkeeper recovery. it is basically a refactor change, which:
    
    - abstract an interface for LedgerEntryRequest in PendingReadOp
    - rename current implementation to SequenceReadRequest, which read the entry in the sequence of quorum.
    
    RB_ID=266137

commit 80ffc6ca86b5e8a63dc3b9baf846ad139d7beea1
Author: Sijie Guo <si...@apache.org>
Date:   2017-06-01T19:11:40Z

    Address conflicts

commit f0fb89cbdfed6c6b0d519a25ea2ea67dcd72834e
Author: Sijie Guo <si...@twitter.com>
Date:   2014-01-21T00:49:52Z

    bookkeeper recovery improvement (part-2): add a parallel reading request in PendingReadOp
    
    - add a parallel reading request in PendingReadOp
    - allow PendingReadOp to configure whether to do parallel reading or not
    - add flag in ClientConfiguration to allow configuring whether to do parallel reading in LedgerRecoveryOp or not.
    
    RB_ID=266139

commit db3e98ba9250b622db80cac8dd6dbd2761a32381
Author: Sijie Guo <si...@apache.org>
Date:   2017-06-01T20:00:01Z

    Address conflicts

commit 8b8a3c8db86a11a30efb14d04b33bfcd461a6f05
Author: Sijie Guo <si...@twitter.com>
Date:   2014-01-21T00:55:30Z

    bookkeeper recovery improvement (part-3): add a ReadEntryListener to callback on individual request.
    
    - add read entry listener which allow doing batch read, but callback on individual entries in sequence. so in recovery op, we could issue batch reads, then on each individual callback do add entry and stop when received NoSuchEntry.
    
    RB_ID=266143

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #178: BOOKKEEPER-1088: Ledger Recovery - Add a ReadEntryLis...

Posted by jvrao <gi...@git.apache.org>.
Github user jvrao commented on the issue:

    https://github.com/apache/bookkeeper/pull/178
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #178: BOOKKEEPER-1088: Ledger Recovery - Add a ReadEntryLis...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/178
  
    LGTM +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #178: BOOKKEEPER-1088: Ledger Recovery (part-3) - Ad...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bookkeeper/pull/178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---