[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16618: Skip creating a subscription replication snapshot if no messages have been published after the topic gets activated on a broker

[GitBox <gi...@apache.org>]

Technoboy- commented on code in PR #16618:
URL: https://github.com/apache/pulsar/pull/16618#discussion_r959240452


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java:
##########
@@ -202,7 +202,8 @@ private void receiveSubscriptionUpdated(ReplicatedSubscriptionsUpdate update) {
     private void startNewSnapshot() {
         cleanupTimedOutSnapshots();
 
-        if (topic.getLastDataMessagePublishedTimestamp() < lastCompletedSnapshotStartTime) {
+        if (topic.getLastDataMessagePublishedTimestamp() < lastCompletedSnapshotStartTime
+                || topic.getLastDataMessagePublishedTimestamp() == 0) {

Review Comment:
   topic.getLastDataMessagePublishedTimestamp() <= lastCompletedSnapshotStartTime ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org