[jira] [Commented] (CAY-1976) Slow performance of DbMerger

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAY-1976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238121#comment-14238121 ] 

ASF GitHub Bot commented on CAY-1976:
-------------------------------------

GitHub user AlexKolonitsky opened a pull request:

    https://github.com/apache/cayenne/pull/46

    CAY-1976 Slow performance of DbMerger

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AlexKolonitsky/cayenne CAY-1976_Slow_performance_of_DbMerger

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cayenne/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit f3457df851a9432b4476245b5674342777414a32
Author: alexkolonitsky <al...@gmail.com>
Date:   2014-12-08T16:52:31Z

    CAY-1976 Slow performance of DbMerger

----


> Slow performance of DbMerger
> ----------------------------
>
>                 Key: CAY-1976
>                 URL: https://issues.apache.org/jira/browse/CAY-1976
>             Project: Cayenne
>          Issue Type: Bug
>    Affects Versions: 4.0.M2
>            Reporter: Andrus Adamchik
>            Assignee: Andrus Adamchik
>             Fix For: 4.0.M2
>
>
> This is a consequence of CAY-1946 refactoring. DbMerger applies "includeTableName" only after full reverse-engineering of the DB. So on databases with lots of system tables invoking DbMerger.createMergeTokens(..) becomes prohibitively slow. This is visible with MergeCase subclasses when running unit tests on PostgreSQL and Oracle.
> E.g. on PostgreSQL 'mvn clean verify' that previously took ~2 min on my laptop, is now taking 1 hour. On Oracle I could not even finish the test run. 
> There is actually a TODO in DbMerger, line 178:
> if (!includeTableName(tableName)) {
>     // TODO we have to cut this entities in db loader
>    // TODO log
>    continue;
> }
> We need to address this one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)