You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/12 16:23:47 UTC
[GitHub] zeppelin pull request #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRET...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2126
[gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' type & Add pagination
### What is this PR for?
After #2037 merged, we can see `INTERPRETER` type in Helium menu. So for the consistency, it'll be better we can show`INTERPRETER` type in https://zeppelin.apache.org/helium_packages.html. So what I did in this PR is
- enabled to show `INTERPRETER` type
- added a pagination
### What type of PR is it?
Improvement
### Todos
* [ ] - update overview sentences
(current overview sentences are only for npm package related description. But`INTERPRETER` type pkgs come from mvn central not npm registry, need to update accordingly)
### What is the Jira issue?
* [ZEPPELIN-2110](https://issues.apache.org/jira/browse/ZEPPELIN-2110) : List community & 3rd party interpreter registered at Maven central repo in Helium menu
* [ZEPPELIN-2209](https://issues.apache.org/jira/browse/ZEPPELIN-2209) : Add pagination
### How should this be tested?
1. To see `INTERPRETER` type pkg, replace [helium online registry uri](https://github.com/apache/zeppelin/blob/gh-pages/_includes/themes/zeppelin/default.html#L34) to [this url](<script src="https://rawgit.com/AhyoungRyu/spark-notebook-example/master/helium-fake.js"></script>)
2. Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website)
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes need to update overview sentences in this page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin add/interpreterTypePkg
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2126
----
commit a2e646e23baa0bf047072368566556b2cb886cd5
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-12T15:57:36Z
Add ui-bootstrap cdn uri to default.html
commit 096dd368e3ede97fe10866fbb2b487e5d5d34630
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-12T15:58:13Z
Add pagination & show 'INTERPRETER' type
commit e303f4844cd4a701306ae9ea745e182ac55902fa
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-03-12T16:03:56Z
Remove unused pagination funcs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2126
@1ambda @felixcheung Thanks!
I updated the overview sentences as well.
- before
- after
@1ambda Is it okay with this overview sentences? What do you think? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2126
Thanks again @1ambda.
Will merge into gh-pages if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRET...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2126
nice!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2126
Looks nice. @AhyoungRyu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2126: [gh-pages][ZEPPELIN-2209, 2110] Show 'INTERPRETER' typ...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2126
Pagination what @AhyoungRyu added is nice.
- Tested and works as described.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---