[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #19: [MSHADE-316] - Configuration option

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #19: [MSHADE-316] - Configuration option <excludeDefaults>
URL: https://github.com/apache/maven-shade-plugin/pull/19#discussion_r275157984
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/filter/SimpleFilter.java
 ##########
 @@ -42,16 +42,19 @@
 
     private Set<String> excludes;
 
+    private boolean excludeDefaults = true;
+
     /**
      * @param jars set of {@link File}s.
      * @param includes set of includes.
      * @param excludes set of excludes
      */
-    public SimpleFilter( Set<File> jars, Set<String> includes, Set<String> excludes )
+    public SimpleFilter( Set<File> jars, Set<String> includes, Set<String> excludes, boolean excludeDefaults )
 
 Review comment:
   It looks to me we're at a point where we need a second constructor, using the `ArchiveFilter` as argument instead of includes/excludes/excludeDefaults.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services