You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "drpmma (via GitHub)" <gi...@apache.org> on 2024/02/29 07:22:03 UTC
[PR] [ISSUE #7875] Add constructor for ProxyTopicRouteData [rocketmq]
drpmma opened a new pull request, #7876:
URL: https://github.com/apache/rocketmq/pull/7876
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7875
### Brief Description
Add constructor for ProxyTopicRouteData
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7875] Add constructor for ProxyTopicRouteData [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7876:
URL: https://github.com/apache/rocketmq/pull/7876#issuecomment-1970587396
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `68.75000%` with `15 lines` in your changes are missing coverage. Please review.
> Project coverage is 42.94%. Comparing base [(`01761bd`)](https://app.codecov.io/gh/apache/rocketmq/commit/01761bdc7a42bcb4e6716d2e2666549b4a9e0a6c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4e11795`)](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on develop.
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ketmq/proxy/service/route/ProxyTopicRouteData.java](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2Uvcm91dGUvUHJveHlUb3BpY1JvdXRlRGF0YS5qYXZh) | 67.39% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7876 +/- ##
=============================================
+ Coverage 42.92% 42.94% +0.02%
- Complexity 9903 9917 +14
=============================================
Files 1190 1190
Lines 86019 86038 +19
Branches 11080 11081 +1
=============================================
+ Hits 36924 36951 +27
+ Misses 44513 44512 -1
+ Partials 4582 4575 -7
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7876?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7875] Add constructor for ProxyTopicRouteData [rocketmq]
Posted by "drpmma (via GitHub)" <gi...@apache.org>.
drpmma merged PR #7876:
URL: https://github.com/apache/rocketmq/pull/7876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org