You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by re...@apache.org on 2016/01/19 17:48:51 UTC
[4/5] git commit: updated refs/heads/master to f98f983
Merge pull request #1319 from nitin-maharana/CloudStack-Nitin15_4.7
CLOUDSTACK-9132: API createVolume takes empty string for name parameterSteps to Reproduce:
================
Create a volume using createVolume API where parameter name is empty.
It creates a volume with empty name.
But the name parameter is mandatory.(Issue)
Expected Behaviour:
================
It shouldn't create a volume with an empty name. Error should be returned.
Solution:
=======
Added a condition to check in case of empty string. If the name is an empty string, it generates a random name for the volume. Made the name field optional in UI as well as in API.
* pr/1319:
CLOUDSTACK-9132: API createVolume takes empty string for name parameter
Signed-off-by: Remi Bergsma <gi...@remi.nl>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/c7ad1b60
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/c7ad1b60
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/c7ad1b60
Branch: refs/heads/master
Commit: c7ad1b6083c45f8292ed31d8039608a116b47eeb
Parents: 57a2a0b 55f8b32
Author: Remi Bergsma <gi...@remi.nl>
Authored: Tue Jan 19 17:44:55 2016 +0100
Committer: Remi Bergsma <gi...@remi.nl>
Committed: Tue Jan 19 17:44:56 2016 +0100
----------------------------------------------------------------------
.../command/user/volume/CreateVolumeCmd.java | 2 +-
.../com/cloud/storage/VolumeApiServiceImpl.java | 24 ++++++++++++++---
.../cloud/storage/VolumeApiServiceImplTest.java | 28 ++++++++++++++++++++
ui/scripts/docs.js | 2 +-
ui/scripts/storage.js | 5 +---
5 files changed, 51 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/c7ad1b60/ui/scripts/docs.js
----------------------------------------------------------------------