[GitHub] [shardingsphere] natehuangting opened a new pull request, #18508: add hint doc

[GitBox <gi...@apache.org>]

natehuangting opened a new pull request, #18508:
URL: https://github.com/apache/shardingsphere/pull/18508

   Changes proposed in this pull request:
   - The MySQL client will filter comments by default and make hint unavailable, so add documentation here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #18508: add hint doc

[GitBox <gi...@apache.org>]

strongduanmu commented on code in PR #18508:
URL: https://github.com/apache/shardingsphere/pull/18508#discussion_r903274608


##########
docs/document/content/user-manual/shardingsphere-jdbc/special-api/sharding/hint.cn.md:
##########
@@ -177,6 +177,7 @@ try (HintManager hintManager = HintManager.getInstance();
 
 SQL Hint 功能需要用户提前开启解析注释的配置，设置 `sqlCommentParseEnabled` 为 `true`，目前只支持路由至一个数据源。
 注释格式暂时只支持 `/* */`，内容需要以 `ShardingSphere hint:` 开始，属性名为 `dataSourceName`。
+如果使用MySQL客户端连接需要添加`-c`选项保留注释，客户端默认是`--skip-comments`过滤注释。

Review Comment:
   Please put spaces before and after `MySQL`, `-c`, `--skip-comments`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #18508: add hint doc

[GitBox <gi...@apache.org>]

strongduanmu merged PR #18508:
URL: https://github.com/apache/shardingsphere/pull/18508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org