[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #6818: TF frontend: add rint op

[GitBox <gi...@apache.org>]

siju-samuel commented on a change in pull request #6818:
URL: https://github.com/apache/incubator-tvm/pull/6818#discussion_r516413347



##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -2391,6 +2391,7 @@ def _impl(inputs, attr, params, mod):
     "ReverseV2": _reverse_v2(),
     "RightShift": AttrCvt("right_shift"),
     "Round": AttrCvt("round"),
+    "Rint": AttrCvt("round"),

Review comment:
       preserve the alphabetical order. keep Rint above Round.

##########
File path: tests/python/frontend/tensorflow/test_forward.py
##########
@@ -3520,6 +3520,23 @@ def _test_forward_softsign(shape):
     _test_forward_softsign([2, 5, 2, 5])
 
 
+def test_forward_rint():
+    """test operator rint """
+
+    def _test_forward_rint(shape):
+        tf.disable_eager_execution()
+        np_data = np.random.uniform(1, 100, size=shape).astype(np.float32)

Review comment:
       include -ve floats also for testing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org