You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Christine Poerschke (Jira)" <ji...@apache.org> on 2021/07/21 17:11:00 UTC
[jira] [Resolved] (SOLR-15496) LTRRescorer unnecessarily
(re)creates ScoreDoc Comparator objects
[ https://issues.apache.org/jira/browse/SOLR-15496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christine Poerschke resolved SOLR-15496.
----------------------------------------
Fix Version/s: 8.10
main (9.0)
Assignee: Christine Poerschke
Resolution: Fixed
Thanks [~marcosfpr]!
> LTRRescorer unnecessarily (re)creates ScoreDoc Comparator objects
> -----------------------------------------------------------------
>
> Key: SOLR-15496
> URL: https://issues.apache.org/jira/browse/SOLR-15496
> Project: Solr
> Issue Type: Task
> Components: ltr
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Labels: newdev
> Fix For: main (9.0), 8.10
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Discovered by [~mdrob] whilst reviewing SOLR-14920 changes:
> A static instance of the comparator(s) could be created and reused.
> * https://github.com/apache/solr/blob/af0455ac8366d6dba941f2b2674ed2a8245c76f9/solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java#L133-L162
> * https://github.com/apache/solr/pull/189#discussion_r657360363
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org