You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/16 13:21:44 UTC
[GitHub] [arrow-rs] ritchie46 opened a new pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
ritchie46 opened a new pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303
This fixes #232.
I really wonder if `#[cfg(simd)]` was correct at all? I couldn't find any documentation backing it, and my IDE showed the code as deactivated no matter what I did (not a really convincing reason, I know :stuck_out_tongue_winking_eye: )
Anyhow, I was able to activate "simd" as a single feature gate:
```toml
arrow = {version="5.0.0-SNAPSHOT", git = "https://github.com/ritchie46/arrow-rs", branch = "feat_simd", default-features=false, features = ["simd"]}
```
And could also compile the docs with:
`$ cargo +nightly doc --all-features`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842264365
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#303](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c9375) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1fc48daab0d915fcd26c919d2fc47a7b057bd13e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fc48da) will **increase** coverage by `0.02%`.
> The diff coverage is `88.26%`.
> :exclamation: Current head 33c9375 differs from pull request most recent head e5cdf04. Consider uploading reports for the commit e5cdf04 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 82.49% 82.52% +0.02%
==========================================
Files 162 162
Lines 43980 44007 +27
==========================================
+ Hits 36282 36315 +33
+ Misses 7698 7692 -6
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `85.29% <ø> (ø)` | |
| [arrow/src/buffer/ops.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9vcHMucnM=) | `96.96% <ø> (ø)` | |
| [arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hZ2dyZWdhdGUucnM=) | `73.40% <ø> (ø)` | |
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `87.36% <ø> (ø)` | |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `95.84% <ø> (ø)` | |
| [arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvYml0X3V0aWwucnM=) | `100.00% <ø> (ø)` | |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `82.61% <87.15%> (+1.38%)` | :arrow_up: |
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <100.00%> (+14.86%)` | :arrow_up: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `95.04% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fc48da...e5cdf04](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 closed pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 closed pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841824883
> Could it be that this does not work when the crate is used as a dependency?
Maybe the mentioned build.rs does not run in such a case? As a dependency, you can also not compile arrow with the `"simd"` feature, so there must be something different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841821361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841819885
🤯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] roee88 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
roee88 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841829369
> I remember the PR that introduced that added some [build.rs magic](https://github.com/apache/arrow-rs/blob/master/arrow/build.rs#L24) using the [cfg_alias crate](https://docs.rs/cfg_aliases/0.1.1/cfg_aliases/), but I never verified that actually worked.
Is it intentional that simd can't be enabled for wasm32 targets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842264365
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#303](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33c9375) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1fc48daab0d915fcd26c919d2fc47a7b057bd13e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fc48da) will **increase** coverage by `0.02%`.
> The diff coverage is `88.26%`.
> :exclamation: Current head 33c9375 differs from pull request most recent head e5cdf04. Consider uploading reports for the commit e5cdf04 to get more accurate results
[](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 82.49% 82.52% +0.02%
==========================================
Files 162 162
Lines 43980 44007 +27
==========================================
+ Hits 36282 36315 +33
+ Misses 7698 7692 -6
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIucnM=) | `85.29% <ø> (ø)` | |
| [arrow/src/buffer/ops.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9vcHMucnM=) | `96.96% <ø> (ø)` | |
| [arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hZ2dyZWdhdGUucnM=) | `73.40% <ø> (ø)` | |
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `87.36% <ø> (ø)` | |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `95.84% <ø> (ø)` | |
| [arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvYml0X3V0aWwucnM=) | `100.00% <ø> (ø)` | |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `82.61% <87.15%> (+1.38%)` | :arrow_up: |
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <100.00%> (+14.86%)` | :arrow_up: |
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `95.04% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fc48da...e5cdf04](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841824883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842238005
I understand that the CI fails because we don't check architectures. Does the `build.rs` file not run, when used as a crate dependency?
Shall I go for the verbose option?:
```
#[cfg(all(any(target_arch = "x86", target_arch = "x86_64", target_arch = "aarch64"), feature = "simd")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841821361
I remember the PR that introduced that added some [build.rs magic][1] using the [cfg_alias crate][2], but I never verified that actually worked.
[1]: https://github.com/apache/arrow-rs/blob/master/arrow/build.rs#L24
[2]: https://docs.rs/cfg_aliases/0.1.1/cfg_aliases/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 closed pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 closed pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] roee88 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
roee88 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841829369
> I remember the PR that introduced that added some [build.rs magic](https://github.com/apache/arrow-rs/blob/master/arrow/build.rs#L24) using the [cfg_alias crate](https://docs.rs/cfg_aliases/0.1.1/cfg_aliases/), but I never verified that actually worked.
Is it intentional that simd can't be enabled for wasm32 targets?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842303334
> Is it intentional that simd can't be enabled for wasm32 targets?
Wasm does not seem to be listed as a [supported platform by packed_simd][1]. I don't have any experience with wasm, but I see no real reason why it should not work if llvm has support for it.
[1]: https://crates.io/crates/packed_simd_2#user-content-platform-support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841821959
I did confirm that there was a performance change back then; I also saw the performance difference when compiled with `simd` about a month ago, although I was only using it on the benches; e.g. `cargo bench --bench X --feature simd`.
Could it be that this does not work when the crate is used as a dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-841819885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842264365
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#303](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2329840) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1fc48daab0d915fcd26c919d2fc47a7b057bd13e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fc48da) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 82.49% 82.52% +0.02%
==========================================
Files 162 162
Lines 43980 44007 +27
==========================================
+ Hits 36282 36315 +33
+ Misses 7698 7692 -6
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/buffer/ops.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9vcHMucnM=) | `96.96% <ø> (ø)` | |
| [arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hZ2dyZWdhdGUucnM=) | `73.40% <ø> (ø)` | |
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `87.36% <ø> (ø)` | |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `95.84% <ø> (ø)` | |
| [arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvYml0X3V0aWwucnM=) | `100.00% <ø> (ø)` | |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `82.61% <0.00%> (+1.38%)` | :arrow_up: |
| [arrow/src/array/transform/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9ib29sZWFuLnJz) | `84.61% <0.00%> (+7.69%)` | :arrow_up: |
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <0.00%> (+14.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fc48da...2329840](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842264365
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#303](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2329840) into [master](https://codecov.io/gh/apache/arrow-rs/commit/1fc48daab0d915fcd26c919d2fc47a7b057bd13e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fc48da) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 82.49% 82.52% +0.02%
==========================================
Files 162 162
Lines 43980 44007 +27
==========================================
+ Hits 36282 36315 +33
+ Misses 7698 7692 -6
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/buffer/ops.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9vcHMucnM=) | `96.96% <ø> (ø)` | |
| [arrow/src/compute/kernels/aggregate.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hZ2dyZWdhdGUucnM=) | `73.40% <ø> (ø)` | |
| [arrow/src/compute/kernels/arithmetic.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9hcml0aG1ldGljLnJz) | `87.36% <ø> (ø)` | |
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `95.84% <ø> (ø)` | |
| [arrow/src/util/bit\_util.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvYml0X3V0aWwucnM=) | `100.00% <ø> (ø)` | |
| [arrow/src/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2ZmaS5ycw==) | `82.61% <0.00%> (+1.38%)` | :arrow_up: |
| [arrow/src/array/transform/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L3RyYW5zZm9ybS9ib29sZWFuLnJz) | `84.61% <0.00%> (+7.69%)` | :arrow_up: |
| [arrow/src/array/ffi.rs](https://codecov.io/gh/apache/arrow-rs/pull/303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2ZmaS5ycw==) | `100.00% <0.00%> (+14.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fc48da...2329840](https://codecov.io/gh/apache/arrow-rs/pull/303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ritchie46 commented on pull request #303: replace #[cfg(simd)] with #[cfg(feature = "simd")]
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #303:
URL: https://github.com/apache/arrow-rs/pull/303#issuecomment-842348212
I am closing this, as it seems already fixed. See #232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org