You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/06/23 10:26:55 UTC
[GitHub] [flink] echauchot opened a new pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
echauchot opened a new pull request #16256:
URL: https://github.com/apache/flink/pull/16256
Updating release notes as discussed
R: @tillrohrmann
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
echauchot commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-874573817
> Hmm, @rmetzger only linked a single merge commit and set the fixVersion to `1.13.0`. If this is indeed the case, could you update the JIRA ticket @echauchot?
My bad, I was fooled by intellij github plugin search feature. The commit is indeed only in 1.13 so everything is ok.
Sorry for the noise :slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
echauchot commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-874023285
> I think I might have given you bad advice. [FLINK-18685](https://issues.apache.org/jira/browse/FLINK-18685) seems to be only fixed in Flink 1.13.0. Hence we only need to update the release docs for 1.13. I will update the PR accordingly.
Hi Till, I'm back from vacations, thanks for review / merge.
The reason why I was updating 1.11, 1.12 and 1.13 is because the jobclient feature commit beae8e7a20dfa915ce02fd3e5186d4b5e71fbbef is present in all 1.11, 1.12 and 1.13 branches not olnly in 1.13 even if the ticket https://issues.apache.org/jira/browse/FLINK-18685 was closed on 1.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-866747913
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18463c0a2319713b7d921dd49845168b3857ef69",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19386",
"triggerID" : "18463c0a2319713b7d921dd49845168b3857ef69",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18463c0a2319713b7d921dd49845168b3857ef69 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #16256:
URL: https://github.com/apache/flink/pull/16256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-866730251
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 18463c0a2319713b7d921dd49845168b3857ef69 (Wed Jun 23 10:42:37 UTC 2021)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-873089696
I think I might have given you bad advice. FLINK-18685 seems to be only fixed in Flink 1.13.0. Hence we only need to update the release docs for 1.13. I will update the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-866747913
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18463c0a2319713b7d921dd49845168b3857ef69",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18463c0a2319713b7d921dd49845168b3857ef69",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18463c0a2319713b7d921dd49845168b3857ef69 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-866747913
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18463c0a2319713b7d921dd49845168b3857ef69",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19386",
"triggerID" : "18463c0a2319713b7d921dd49845168b3857ef69",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18463c0a2319713b7d921dd49845168b3857ef69 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=19386)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] echauchot commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
echauchot commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-874023285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-874154398
Hmm, @rmetzger only linked a single merge commit and set the fixVersion to `1.13.0`. If this is indeed the case, could you update the JIRA ticket @echauchot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #16256: [hotfix][release-notes] Update release notes for 1.11, 1.12, 1.13 with accumulators semantics change in MiniClusterJobClient
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #16256:
URL: https://github.com/apache/flink/pull/16256#issuecomment-874154398
Hmm, @rmetzger only linked a single merge commit and set the fixVersion to `1.13.0`. If this is indeed the case, could you update the JIRA ticket @echauchot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org