You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 13:38:43 UTC

[GitHub] [beam] damccorm opened a new issue, #19819: Remove deprecated 'compare' argument from combiners.Top in PyDocs

damccorm opened a new issue, #19819:
URL: https://github.com/apache/beam/issues/19819

   PyDoc: [https://beam.apache.org/releases/pydoc/2.12.0/apache_beam.transforms.combiners.html?#apache_beam.transforms.combiners.Top](https://beam.apache.org/releases/pydoc/2.12.0/apache_beam.transforms.combiners.html?#apache_beam.transforms.combiners.Top)
   
   The combiners.Top PyDoc still shows the `compare` argument as usable. It is deprecated and results in an error in Python 3, but the PyDoc does not reflect that.
   
   It should say that the argument is deprecated in favor of using the `key` and `reverse` arguments.
   
   Imported from Jira [BEAM-8784](https://issues.apache.org/jira/browse/BEAM-8784). Original Jira may contain additional context.
   Reported by: dcavazos.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] Abacn commented on issue #19819: Remove deprecated 'compare' argument from combiners.Top in PyDocs

Posted by GitBox <gi...@apache.org>.
Abacn commented on issue #19819:
URL: https://github.com/apache/beam/issues/19819#issuecomment-1367446140

   compare argument is gone, but the documentation still refers to it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org