You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ch...@apache.org on 2017/07/27 15:23:01 UTC

carbondata git commit: [CARBONDATA-1287] remove unnecessary MDK generation

Repository: carbondata
Updated Branches:
  refs/heads/master 8f3cf9ab5 -> c504dd2d0


[CARBONDATA-1287] remove unnecessary MDK generation

This closes #1145


Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/c504dd2d
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/c504dd2d
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/c504dd2d

Branch: refs/heads/master
Commit: c504dd2d0754289d6ba8424313b54379b017e142
Parents: 8f3cf9a
Author: jackylk <ja...@huawei.com>
Authored: Fri Jul 7 19:11:05 2017 +0800
Committer: chenliang613 <ch...@apache.org>
Committed: Thu Jul 27 23:22:49 2017 +0800

----------------------------------------------------------------------
 .../org/apache/carbondata/processing/store/TablePageKey.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/carbondata/blob/c504dd2d/processing/src/main/java/org/apache/carbondata/processing/store/TablePageKey.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/store/TablePageKey.java b/processing/src/main/java/org/apache/carbondata/processing/store/TablePageKey.java
index 3cb4777..a66575e 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/store/TablePageKey.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/store/TablePageKey.java
@@ -54,17 +54,16 @@ public class TablePageKey {
 
   /** update all keys based on the input row */
   void update(int rowId, CarbonRow row) throws KeyGenException {
-    byte[] currentMDKey = WriteStepRowUtil.getMdk(row, model.getMDKeyGenerator());
     if (model.getNoDictionaryCount() > 0 || model.getComplexIndexMap().size() > 0) {
       currentNoDictionaryKey = WriteStepRowUtil.getNoDictAndComplexDimension(row);
     }
     if (rowId == 0) {
-      startKey = currentMDKey;
+      startKey = WriteStepRowUtil.getMdk(row, model.getMDKeyGenerator());
       noDictStartKey = currentNoDictionaryKey;
     }
-    endKey = currentMDKey;
     noDictEndKey = currentNoDictionaryKey;
     if (rowId == pageSize - 1) {
+      endKey = WriteStepRowUtil.getMdk(row, model.getMDKeyGenerator());
       finalizeKeys();
     }
   }