You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/30 20:32:25 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5805: Minor: fix flaking test
alamb opened a new pull request, #5805:
URL: https://github.com/apache/arrow-datafusion/pull/5805
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/pull/5792
# Rationale for this change
One of the tests added in https://github.com/apache/arrow-datafusion/pull/5792 intermittently fails due to ordering mismatch -- for example
https://github.com/apache/arrow-datafusion/actions/runs/4568420322/jobs/8063658835?pr=5803
```
[Diff] (-expected|+actual)
- 0 years 0 mons 5 days 0 hours 0 mins 0.000000003 secs Interval(MonthDayNano)
- 0 years 0 mons 6 days 0 hours 0 mins 0.000000007 secs Interval(MonthDayNano)
+ 0 years 0 mons 6 days 0 hours 0 mins 0.000000007 secs Interval(MonthDayNano)
+ 0 years 0 mons 5 days 0 hours 0 mins 0.000000003 secs Interval(MonthDayNano)
at tests/sqllogictests/test_files/interval.slt:59
```
# What changes are included in this PR?
Add sorting to test script to make test deterministic
# Are these changes tested?
yes
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5805: Minor: fix flaking test
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5805:
URL: https://github.com/apache/arrow-datafusion/pull/5805#issuecomment-1490992997
I am going to merge this to try and avoid causing other people problems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5805: Minor: fix flaking test
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5805:
URL: https://github.com/apache/arrow-datafusion/pull/5805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org