[GitHub] [incubator-dolphinscheduler] hgaol commented on issue #2869: [Proposal] DolphinScheduler Plugin Design

[GitBox <gi...@apache.org>]

hgaol commented on issue #2869:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/2869#issuecomment-637563189


   Cool, that's what I want to do. As you said, it can't solve the nested fields problems. I think it's fine for alert plugin, as for job plugin, I'm not sure it will meet the demands.
   
   For the current problems, here is my opinions:
   1. Do we need a table to save the plugin instance information?
   I think the answer is 'yes'. IMO, we need 2 new tables, one is plugin_definition, the other is plugin_instance. For plugin_definition, it has id, ch_json, en_json fields. For plugin_instance, it save the values based on the definition.
   
   2. As mentioned above, we should save the plugin instance information. If the plugin has been removed, it should alert through log, mail, or something else. And user do not need to file the form again.
   
   This is my opinion :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org