You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/14 21:14:24 UTC
[GitHub] [incubator-yunikorn-web] craigcondit opened a new pull request #71: [YUNIKORN-1105] Use bytes as base unit for memory
craigcondit opened a new pull request #71:
URL: https://github.com/apache/incubator-yunikorn-web/pull/71
### What is this PR for?
Use bytes as the base unit of memory, as the scheduler will now use absolute values.
This should be committed at the same time as the shim PR.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1105
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #71: [YUNIKORN-1105] Use bytes as base unit for memory
Posted by GitBox <gi...@apache.org>.
akhilpb001 commented on a change in pull request #71:
URL: https://github.com/apache/incubator-yunikorn-web/pull/71#discussion_r828802939
##########
File path: src/app/utils/common.util.ts
##########
@@ -30,9 +30,19 @@ export class CommonUtil {
}
static formatMemory(value: number | string): string {
- let unit = 'MB';
+ let unit = 'bytes';
Review comment:
nit: Would it be better to the casing of `bytes` to `Bytes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] wilfred-s closed pull request #71: [YUNIKORN-1105] Use bytes as base unit for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #71:
URL: https://github.com/apache/incubator-yunikorn-web/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-web] wilfred-s commented on pull request #71: [YUNIKORN-1105] Use bytes as base unit for memory
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #71:
URL: https://github.com/apache/incubator-yunikorn-web/pull/71#issuecomment-1068671334
@akhilpb001 would like to make sure that you have seen this change before we commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org