You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@myfaces.apache.org by mm...@apache.org on 2007/07/27 10:38:25 UTC

svn commit: r560145 - /myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java

Author: mmarinschek
Date: Fri Jul 27 01:38:24 2007
New Revision: 560145

URL: http://svn.apache.org/viewvc?view=rev&rev=560145
Log:
https://issues.apache.org/jira/browse/MYFACES-1685: exception also if response is committed, logging if error-page is shown

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java?view=diff&rev=560145&r1=560144&r2=560145
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java Fri Jul 27 01:38:24 2007
@@ -18,6 +18,9 @@
  */
 package javax.faces.webapp;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import javax.faces.context.FacesContext;
 import java.io.Writer;
 import java.beans.BeanInfo;
@@ -51,6 +54,8 @@
  */
 public final class _ErrorPageWriter {
 
+    private static final Log log = LogFactory.getLog(_ErrorPageWriter.class);
+
     private final static String TS = "&lt;";
 
     private static final String ERROR_TEMPLATE = "META-INF/rsc/facelet-dev-error.xml";
@@ -317,6 +322,11 @@
                 Writer writer = httpResp.getWriter();
 
                 debugHtml(writer, facesContext, ex);
+
+                log.error("An exception occurred", ex);
+            }
+            else {
+                throwException(ex);
             }
         }
         else {