You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@commons.apache.org by sesuncedu <gi...@git.apache.org> on 2017/06/22 17:40:47 UTC
[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...
GitHub user sesuncedu opened a pull request:
https://github.com/apache/commons-compress/pull/39
COMPRESS-413: Performance improvements for Travis builds
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could be run in an after_success script. That script could restrict coveralls notification to a single point in the jdk matrix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T20:15:16Z
add mvnw
(cherry picked from commit 91a08f4)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T16:13:45Z
COMPRESS-413
Alter pom.xml:
- Add Simon Spero as contributor.
- change javadoc configuration to use <docencoding> (lowercase e) instead of <docEncoding> (uppercase E).
- see https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
- exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they already have APL header).
- add plugin configuration for coveralls to pluginManagement. Set failOnServiceError to false to avoid breaking the build
if coveralls is not available
Signed-off-by: Simon Spero <se...@gmail.com>
commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T17:00:13Z
COMPRESS-413
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could run in a after_success script that checked and only ran for a selected jdk
Signed-off-by: Simon Spero <se...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12093695)
Coverage increased (+0.09%) to 84.815% when pulling **a434e5866df38e4b1f089c280f0b1a784e41a86d on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/commons-compress/pull/39
Thanks Simon.
TBH I'm not too sure why we've got Travis builds at all, probably so we can run Coveralls. I'll leave this request open for those more interested in the Travis CI setup. I'll rather invest some time in adding a Jenkins matrix build for the JDKs we want to support instead.
Commons Compress aims to be compatible with Java7, no matter how old or deprecated, but we already cover that with Jenkins - the pull request builder over there uses Oracle JDK 7, so we've got that covered independent of Travis CI. We do run SonarQube for Compress already.
Personally I dislike `mvnw` scripts, but this is probably a matter of taste. I won't veto its introduction.
Please strip the changes to `AsiExtraField` from this PR, they are completely unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...
Posted by sesuncedu <gi...@git.apache.org>.
GitHub user sesuncedu reopened a pull request:
https://github.com/apache/commons-compress/pull/39
COMPRESS-413: Performance improvements for Travis builds
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could be run in an after_success script. That script could restrict coveralls notification to a single point in the jdk matrix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sesuncedu/commons-compress COMPRESS-413
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-compress/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit ed024e9a6de41f72655674f0c7cdcce5700cf82d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-19T20:15:16Z
add mvnw
(cherry picked from commit 91a08f4)
Signed-off-by: Simon Spero <se...@gmail.com>
commit 8d543fd017f5c963f25541109fd48ceba1e0666c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T16:13:45Z
COMPRESS-413
Alter pom.xml:
- Add Simon Spero as contributor.
- change javadoc configuration to use <docencoding> (lowercase e) instead of <docEncoding> (uppercase E).
- see https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#docencoding
- exclude .mvn/** from rat check (mvnw and mvnw.cmd are ok since they already have APL header).
- add plugin configuration for coveralls to pluginManagement. Set failOnServiceError to false to avoid breaking the build
if coveralls is not available
Signed-off-by: Simon Spero <se...@gmail.com>
commit 95974fc671661244c83fdead2231f8367a67d2ba
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T17:00:13Z
COMPRESS-413
Change travis configuration to
- skip pre-build install (which runs the install goal).
- remove after_success code.
- use mvnw to use up-to-date version of maven.
- run all goals/phases previously included in after_sucess phase, using -Ptravis-jacoco profile if one exists.
- clean
- apache-rat:check
- test
- jacoco:report
- coveralls:report
- This will fail the build if any of the above goals fail. The goals that are most likely to fail are: apache-rat:check and test. coveralls configuration is changed in pom to not fail the build if the service is not available (e.g. for forks that do not have repository registered with coveralls).
- Note that the apache-rat: check could be added to the pom (executing by default in the validate phase)
- Also note that the jacoco:check goal can be added to the pom (executing by default in the verify phase).
- the script could then be changed to execute the verify goal.
- coveralls stuff could run in a after_success script that checked and only ran for a selected jdk
Signed-off-by: Simon Spero <se...@gmail.com>
commit 7b4ecc9e7c9d2fb32ddfe4f92791aacf9f17d901
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T18:32:48Z
Switch to trusty container.
Use only openjdk7 and openjdk8 as jdks
Signed-off-by: Simon Spero <se...@gmail.com>
commit 0a61bfde39bb3e8122101622bb96ca918f85ebc7
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T18:42:00Z
Add comment to .travis.yml
Signed-off-by: Simon Spero <se...@gmail.com>
commit a632a7f090ab8dc673fb57f22709bdaddf3ee802
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T20:12:56Z
Cover last two extra lines in ExplodingInputStream
Signed-off-by: Simon Spero <se...@gmail.com>
commit 05b849faf0b1fee3d462b71d9e2c350ba791b06c
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T20:32:16Z
Cover last three lines in BinaryTree
Signed-off-by: Simon Spero <se...@gmail.com>
commit 5d82b0d7ff4f2664e35602ad5bfe1353e764fa79
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T20:59:47Z
Implement AsiExtraField clone without calling super method, to avoid coverage tests complaining that an impossible exception has not been thrown.
Test parsing AsiExtraField as if it came from central directory (identical to local). Because coverage.
Signed-off-by: Simon Spero <se...@gmail.com>
commit a434e5866df38e4b1f089c280f0b1a784e41a86d
Author: Simon Spero <se...@gmail.com>
Date: 2017-06-22T21:05:43Z
New JarMarkerTest to make JarMarker throw an exception, bring coverage up to 100%
Signed-off-by: Simon Spero <se...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12093740)
Coverage increased (+0.1%) to 84.828% when pulling **a434e5866df38e4b1f089c280f0b1a784e41a86d on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu closed the pull request at:
https://github.com/apache/commons-compress/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress pull request #39: COMPRESS-413: Performance improvements fo...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu closed the pull request at:
https://github.com/apache/commons-compress/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12091097)
Coverage decreased (-0.008%) to 84.72% when pulling **0a61bfde39bb3e8122101622bb96ca918f85ebc7 on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12090041)
Coverage remained the same at 84.728% when pulling **95974fc671661244c83fdead2231f8367a67d2ba on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu commented on the issue:
https://github.com/apache/commons-compress/pull/39
Replaced by PR https://github.com/apache/commons-compress/pull/43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12090926)
Coverage decreased (-0.008%) to 84.72% when pulling **7b4ecc9e7c9d2fb32ddfe4f92791aacf9f17d901 on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-compress/pull/39
[](https://:/builds/12118668)
Coverage increased (+0.04%) to 84.766% when pulling **233536b0d1b1df8296fe254c59af5bed7e8c3e32 on sesuncedu:COMPRESS-413** into **4be9979b45ceadc50dc24607884d34613fead1f5 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu commented on the issue:
https://github.com/apache/commons-compress/pull/39
Randomly adding coverage tests for coveralls
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-compress issue #39: COMPRESS-413: Performance improvements for Travi...
Posted by sesuncedu <gi...@git.apache.org>.
Github user sesuncedu commented on the issue:
https://github.com/apache/commons-compress/pull/39
Closing because there's a new PR without the coveralls bait.
Coveralls complains.
The mvnw is not essential yet, but it's good to have 3.5.0 in place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---