You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by hachikuji <gi...@git.apache.org> on 2017/09/08 03:19:09 UTC
[GitHub] kafka pull request #3813: MINOR: Move request/response schemas to the corres...
GitHub user hachikuji opened a pull request:
https://github.com/apache/kafka/pull/3813
MINOR: Move request/response schemas to the corresponding object representation
This refactor achieves the following:
1. Breaks up the increasingly unmanageable `Protocol` class.
2. Removes the need for redundant field identifiers maintained separately in `Protocol` and the respective request/response objects.
3. Provides a better mechanism for sharing common fields between different schemas (e.g. topics, partitions, error codes, etc.).
4. Adds convenience helpers to `Struct` for common patterns (such as setting a field only if it exists).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hachikuji/kafka protocol-schema-refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3813
----
commit 9d008c806e43f7a13221fd5761aed79fb9b4f2cf
Author: Jason Gustafson <ja...@confluent.io>
Date: 2017-09-07T22:34:27Z
MINOR: Move request/response schemas to the corresponding object representation
----
---
[GitHub] kafka pull request #3813: MINOR: Move request/response schemas to the corres...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3813
---