You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2022/09/16 09:26:24 UTC
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18994
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
WIP: Build Impala with cdw dependencies
Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M java/pom.xml
4 files changed, 36 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/1
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8579/
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 16:17:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11473/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 22:49:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8632/
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 19:54:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18994
to look at the new patch set (#2).
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
WIP: Build Impala with cdw dependencies
Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M java/pom.xml
4 files changed, 69 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/2
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8578/
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 11:13:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: IMPALA-11627: Build Impala with cdw dependencies
......................................................................
Patch Set 6:
Thanks for the comment!
I am postponing this change as https://gerrit.cloudera.org/#/c/19149/ was merged and it bumps to a version of CDP that already contains the Hive changes I need. I still think that it will be useful to bump to a mixed cdp/cdw dependency in the future, but it is no longer urgent.
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Nov 2022 13:13:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18994
to look at the new patch set (#6).
Change subject: IMPALA-11627: Build Impala with cdw dependencies
......................................................................
IMPALA-11627: Build Impala with cdw dependencies
The change switches to download cdw versions of Hive dependencies.
As cdw depends on older versions of some components than cdp,
this is a step back from some components, but this didn't lead
to test failures.
For maven artifects both cdp and cdw versions are downloaded
and added as repositiories, so all component can find the
versions it depends on.
Other changes:
- updated resource-requirements.test due to different number
of files tpch_orc_def.lineitem
- added redirections/implementations for new HMS APIs in
MetastoreService
- fixes the bug mentioned in IMPALA-11397
Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M java/pom.xml
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
8 files changed, 249 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/6
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18994
to look at the new patch set (#3).
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
WIP: Build Impala with cdw dependencies
Other changes:
- updated resource-requirements.test due to different number
of files tpch_orc_def.lineitem
- added redirections/implementations for new HMS APIs in
MetastoreService
- fixes the bug mentioned in IMPALA-11397
Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M java/pom.xml
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
8 files changed, 249 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/3
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18994/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/18994/3/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@308
PS3, Line 308: dropDbIfExists(dropDatabaseRequest.getName(), dropDatabaseRequest.isIgnoreUnknownDb(),
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 15:27:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18994
to look at the new patch set (#5).
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
WIP: Build Impala with cdw dependencies
Other changes:
- updated resource-requirements.test due to different number
of files tpch_orc_def.lineitem
- added redirections/implementations for new HMS APIs in
MetastoreService
- fixes the bug mentioned in IMPALA-11397
Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
---
M bin/impala-config.sh
M bin/jenkins/archive_m2_directory.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
M fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
M java/pom.xml
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
8 files changed, 249 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/94/18994/5
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 2:
During the last run only some FE tests have failed: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17579/
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 16:24:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11367/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 11:21:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8632/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 15:27:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies
Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: IMPALA-11627: Build Impala with cdw dependencies
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18994/6/java/pom.xml
File java/pom.xml:
http://gerrit.cloudera.org:8080/#/c/18994/6/java/pom.xml@109
PS6, Line 109:
nit: wrong indentation?
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 23:03:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11627: Build Impala with cdw dependencies
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: IMPALA-11627: Build Impala with cdw dependencies
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <hs...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11366/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 09:47:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11468/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 15:48:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8637/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 22:28:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Sep 2022 03:40:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18994/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java
File fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java:
http://gerrit.cloudera.org:8080/#/c/18994/5/fe/src/main/java/org/apache/impala/catalog/metastore/CatalogMetastoreServiceHandler.java@308
PS5, Line 308: dropDbIfExists(dropDatabaseRequest.getName(), dropDatabaseRequest.isIgnoreUnknownDb(),
line too long (92 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Sep 2022 22:28:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8578/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 09:27:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: Build Impala with cdw dependencies
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18994 )
Change subject: WIP: Build Impala with cdw dependencies
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8579/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18994
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id379030f4b314e139c875584eee438b7416d89a4
Gerrit-Change-Number: 18994
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 10:59:37 +0000
Gerrit-HasComments: No